Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BasicUI] Upgrade Material Icons #2724

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

lolodomo
Copy link
Contributor

Signed-off-by: Laurent Garnier [email protected]

@lolodomo lolodomo added the basic ui Basic UI label Aug 20, 2024
@lolodomo lolodomo requested a review from a team as a code owner August 20, 2024 17:45
@lolodomo lolodomo force-pushed the upgrade_material_icons branch 4 times, most recently from 4f62b9e to 377af8a Compare August 20, 2024 19:17
@lolodomo lolodomo marked this pull request as draft August 20, 2024 23:32
@lolodomo
Copy link
Contributor Author

I removed the package-lock.json and it was recreated. Maybe a wrong idea.

@lolodomo lolodomo force-pushed the upgrade_material_icons branch from 377af8a to 4694ba1 Compare August 21, 2024 06:32
@lolodomo
Copy link
Contributor Author

lolodomo commented Aug 21, 2024

Ok, done again without removing package-lock.json.

@lolodomo lolodomo marked this pull request as ready for review August 21, 2024 06:32
@lolodomo
Copy link
Contributor Author

I will recompile and provide the updated package-lock.json. once #2722 is merged.

@lolodomo lolodomo marked this pull request as draft August 21, 2024 06:55
Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo force-pushed the upgrade_material_icons branch from 4694ba1 to ddf81d4 Compare August 21, 2024 22:17
@lolodomo lolodomo marked this pull request as ready for review August 21, 2024 22:18
@lolodomo
Copy link
Contributor Author

@kaikreuzer : ready for a merge

@kaikreuzer kaikreuzer merged commit 6139039 into openhab:main Aug 23, 2024
5 checks passed
@kaikreuzer kaikreuzer added this to the 4.3 milestone Aug 23, 2024
@lolodomo lolodomo deleted the upgrade_material_icons branch August 23, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
basic ui Basic UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants