Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup wizard: Fix server-set region and location not shown on later wizard launch #2558

Merged
merged 1 commit into from
May 2, 2024

Conversation

florian-h05
Copy link
Contributor

This makes the setup wizard load the region and the location from the server.
Useful when the wizard is re-launched later.

This makes the setup wizard load the region and the location from the server.
Useful when the wizard is re-launched later.

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 requested a review from a team as a code owner May 2, 2024 10:49
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels May 2, 2024
@florian-h05 florian-h05 modified the milestones: 4.1, 4.2 May 2, 2024
Copy link

relativeci bot commented May 2, 2024

#1934 Bundle Size — 10.58MiB (~+0.01%).

0f20a6e(current) vs 14a6c9e main#1933(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#1934
     Baseline
#1933
No change  Initial JS 1.86MiB 1.86MiB
No change  Initial CSS 607.87KiB 607.87KiB
No change  Cache Invalidation 17.78% 17.78%
No change  Chunks 222 222
No change  Assets 245 245
No change  Modules 2873 2873
No change  Duplicate Modules 146 146
No change  Duplicate Code 1.84% 1.84%
No change  Packages 95 95
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#1934
     Baseline
#1933
Regression  JS 8.77MiB (~+0.01%) 8.77MiB
No change  CSS 890.63KiB 890.63KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.24KiB 1.24KiB
No change  Other 871B 871B

Bundle analysis reportBranch florian-h05:setup-wizardProject dashboard

@florian-h05 florian-h05 merged commit 6f5a59f into openhab:main May 2, 2024
6 checks passed
@florian-h05 florian-h05 deleted the setup-wizard branch May 2, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant