Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BasicUI] Implement press & release button #2536

Merged
merged 3 commits into from
May 6, 2024

Conversation

lolodomo
Copy link
Contributor

Related to openhab/openhab-core#3822

Depends on openhab/openhab-core#4183

Signed-off-by: Laurent Garnier [email protected]

@lolodomo lolodomo added enhancement New feature or request basic ui Basic UI awaiting other PR Depends on another PR labels Apr 20, 2024
@lolodomo lolodomo requested a review from a team as a code owner April 20, 2024 11:25
@lolodomo lolodomo marked this pull request as draft April 20, 2024 13:25
@lolodomo lolodomo force-pushed the basicui_press_release branch from 94ba880 to 3603f34 Compare April 20, 2024 16:06
@lolodomo lolodomo marked this pull request as ready for review April 20, 2024 16:07
@lolodomo lolodomo added rebuild trigger a new Jenkins job and removed awaiting other PR Depends on another PR rebuild trigger a new Jenkins job labels May 5, 2024
@lolodomo
Copy link
Contributor Author

lolodomo commented May 6, 2024

Ready for review, the core PRs are now merged.

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kaikreuzer kaikreuzer merged commit 02024c6 into openhab:main May 6, 2024
3 checks passed
@kaikreuzer kaikreuzer added this to the 4.2 milestone May 6, 2024
@lolodomo lolodomo deleted the basicui_press_release branch May 6, 2024 18:57
lolodomo added a commit to lolodomo/openhab-webui that referenced this pull request May 9, 2024
Was added when implementing openhab#2536 for test purpose and I forgot to remove it.

Signed-off-by: Laurent Garnier <[email protected]>
kaikreuzer pushed a commit that referenced this pull request May 10, 2024
Was added when implementing #2536 for test purpose and I forgot to
remove it.

Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
basic ui Basic UI enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants