oh-colorpicker: Fix command not sent when state null & style not accepted & cosmetic error on missing defaultColor #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Job #1092: Bundle Size — 15.75MiB (~+0.01%).Metrics (2 changes)
Total size by type (2 changes)
|
florian-h05
changed the title
Fixes openhab#1713. Signed-off-by: Florian Hotze <[email protected]>
florian-h05
changed the title
Signed-off-by: Florian Hotze <[email protected]>
|
@ghys Can you please have a look at that? |
ghys
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Sorry for letting this slide; I can't really test myself as I've never been confronted to the situation but I remember reports when for example HSB components were rounded and it caused trouble like these infinite loops. I guess if there are side-effects we'll know soon enough :)
stefan-hoehn
pushed a commit
to stefan-hoehn/openhab-webui
that referenced
this pull request
Sep 23, 2023
…pted & cosmetic error on missing defaultColor (openhab#1989) Fixes openhab#1713. - Fix command not sent when current Item state is null. - Fix style can not be set. - Fix a (cosmetic) error thrown when defaultColor has no value. --------- Signed-off-by: Florian Hotze <[email protected]> Signed-off-by: Stefan Höhn <[email protected]>
digitaldan
pushed a commit
to digitaldan/openhab-webui
that referenced
this pull request
Sep 24, 2023
…pted & cosmetic error on missing defaultColor (openhab#1989) Fixes openhab#1713. - Fix command not sent when current Item state is null. - Fix style can not be set. - Fix a (cosmetic) error thrown when defaultColor has no value. --------- Signed-off-by: Florian Hotze <[email protected]>
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Oct 14, 2023
Fixes openhab#2134. Regression from openhab#1989. Signed-off-by: Florian Hotze <[email protected]>
florian-h05
added a commit
that referenced
this pull request
Oct 29, 2023
Fixes #2134. Regression from #1989. Signed-off-by: Florian Hotze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1713.
@ghys Please test this so we don't run into infinite command loops.