Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items: Fix unit metadata not available for UoM groups #1936

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

florian-h05
Copy link
Contributor

Fixes #1933.
Follow-up for #1901.

This enables the unit metadata for UoM groups (i.e. groups with a groupType of Number:).

Fixes openhab#1933.
Follow-up for openhab#1901.

This enables the unit metadata for UoM groups (i.e. groups with a groupType of `Number:`).

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Jun 24, 2023
@florian-h05 florian-h05 added this to the 4.0 milestone Jun 24, 2023
@florian-h05 florian-h05 requested a review from a team as a code owner June 24, 2023 10:47
@relativeci
Copy link

relativeci bot commented Jun 24, 2023

Job #1043: Bundle Size — 15.77MiB (-0.39%).

e6a1b8c(current) vs e0e328c main#1042(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (5 changes)
                 Current
Job #1043
     Baseline
Job #1042
Initial JS 1.74MiB(-0.01%) 1.74MiB
Initial CSS 608.89KiB 608.89KiB
Cache Invalidation 93.96% 93.98%
Chunks 219 219
Assets 689 689
Modules 1720(-0.46%) 1728
Duplicate Modules 85(-3.41%) 88
Duplicate Code 1.72%(-10.42%) 1.92%
Packages 138 138
Duplicate Packages 15 15
Total size by type (3 changes)
                 Current
Job #1043
     Baseline
Job #1042
CSS 858.62KiB (-0.08%) 859.34KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.26MiB (-0.46%) 9.3MiB
Media 295.6KiB 295.6KiB
Other 4.74MiB (-0.37%) 4.75MiB

View job #1043 reportView main branch activity

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for keeping up on the UoM stuff

@ghys ghys merged commit 8228411 into openhab:main Jun 28, 2023
@florian-h05 florian-h05 deleted the group-metadata-unit branch June 28, 2023 20:38
@florian-h05
Copy link
Contributor Author

FYI, there is actually still something missing: On Item creation, there should be a unit field that is pre-filled with the system default unit for the chosen dimension. This way the unit metadata is set for new Items and it is ensured, that even when changing the measurement system, your persisted data won't get corrupted.

openhab/openhab-core#3611 added an REST endpoint for UoM information (all available dimensions with their system default unit), I plan to introduce a Vuex store for this data. I will also use this store for the Item type dialog, we then don't need to keep up with new dimensions as in #1926.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing "Unit" selection for the metadata of a Group Item
2 participants