-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[basicui] Use sitemap input hint v2 #1923
Conversation
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
3fa063d
to
b363e09
Compare
@mherwege : for your information, I have done tests for number and I discovered 2 issues:
For number with dimension, except problem 2, it seems to work well. For problem 1, as it was working well before, I assume there is a link with the change you did in core framework. The problem is in the JavaScript as I see no command sent to the server in the event log. I will try to solve these 2 issues. |
The java script code was not touched in 3d6aa48, the commit adapting to the change in core. So both problems may already have been there with the other PR, or caused by the change in core. |
But in fact, I did not test recently to fill a value. |
But this method works for number with dimension so I am not sure. That is strange. |
Signed-off-by: Laurent Garnier <[email protected]>
I am not able to reproduce problem 2 (bad value restored) now ! |
Make sure to first change it to another good value and only then try clearing the field. If there is an issue, it may be after a first successful update. |
…r is defined Signed-off-by: Laurent Garnier <[email protected]>
I just made more tests for numbers whatever the hint and that looks good. I did not test again date/time hints but I made intensive tests and feedback few months ago on that part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
Thank you for all your review and adjustment effort. |
Thank you to you first :) I opened an issue for the remaining (minor) issue. I will try to fix it next week. I should check if this is specific to Firefox or not. |
This PR is a continuation of #1787, using the extra functionality provided by core if openhab/openhab-core#3644 gets merged in core. It would be an alternative to #1787 with the same functionality, but reduced complexity.
Requires openhab/openhab-core#3644.