Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foreground-service: Remove visibility change listener beforeDestroy #1885

Merged
merged 1 commit into from
May 9, 2023

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented May 8, 2023

... and check for foreground before starting foreground activity.

Follow-up for #1878.

… & Check for foreground

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 requested a review from a team as a code owner May 8, 2023 20:03
@florian-h05
Copy link
Contributor Author

@ghys This is a hotfix for my PR from yesterday, I forgot to remove the event listener beforeDestroy. Can you please have a look at this soon? Thanks!

@florian-h05 florian-h05 added this to the 4.0 milestone May 8, 2023
@relativeci
Copy link

relativeci bot commented May 8, 2023

Job #978: Bundle Size — 15.76MiB (+0.61%).

45b57d6(current) vs 2f7bd09 main#977(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (5 changes)
                 Current
Job #978
     Baseline
Job #977
Initial JS 1.73MiB(+4.25%) 1.66MiB
Initial CSS 608.89KiB 608.89KiB
Cache Invalidation 93.91% 93.95%
Chunks 219 219
Assets 689 689
Modules 1719(+1.66%) 1691
Duplicate Modules 85(-2.3%) 87
Duplicate Code 1.73%(-1.7%) 1.76%
Packages 138 138
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #978
     Baseline
Job #977
CSS 858.62KiB 858.62KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.25MiB (+0.68%) 9.19MiB
Media 295.6KiB 295.6KiB
Other 4.73MiB (+0.7%) 4.7MiB

View job #978 reportView main branch activity

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Florian!

@ghys ghys merged commit a1929a6 into openhab:main May 9, 2023
@florian-h05 florian-h05 deleted the fix-foreground-service branch May 9, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants