-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dynamic icons only for some icon types in default list widget #1874
Conversation
Follow-up for openhab#1849. Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
@ghys This sets the iconUseState to true only for Item types that have a "predictable" state. For groups, the group type is checked. |
Job #957: Bundle Size — 15.75MiB (~-0.01%).Metrics (2 changes)
Total size by type (2 changes)
|
@ghys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It's far better than enabling it in all cases IMO.
The added inline documentation is also very valuable so we know when these are enabled or disabled by default, and the user can make their own choice.
For everyone, it is now enabled by default only for Contact', Dimmer, Rollershutter and Switch item types. |
Follow-up for #1849.