Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dynamic icons only for some icon types in default list widget #1874

Merged
merged 4 commits into from
May 7, 2023

Conversation

florian-h05
Copy link
Contributor

Follow-up for #1849.

@florian-h05 florian-h05 requested a review from a team as a code owner May 6, 2023 21:03
@florian-h05
Copy link
Contributor Author

@ghys This sets the iconUseState to true only for Item types that have a "predictable" state. For groups, the group type is checked.

@relativeci
Copy link

relativeci bot commented May 6, 2023

Job #957: Bundle Size — 15.75MiB (~-0.01%).

4b9444f(current) vs b5f1e95 main#956(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (2 changes)
                 Current
Job #957
     Baseline
Job #956
Initial JS 1.73MiB(~-0.01%) 1.73MiB
Initial CSS 608.85KiB 608.85KiB
Cache Invalidation 93.94% 0%
Chunks 219 219
Assets 689 689
Modules 1717 1717
Duplicate Modules 85 85
Duplicate Code 1.73% 1.73%
Packages 137 137
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #957
     Baseline
Job #956
CSS 858.58KiB 858.58KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.24MiB (~-0.01%) 9.24MiB
Media 295.6KiB 295.6KiB
Other 4.73MiB (~-0.01%) 4.73MiB

View job #957 reportView main branch activity

@florian-h05
Copy link
Contributor Author

@ghys
So this is the only PR left for now that I can’t review myself, but I’ll try keeping you busy with more PRs 😉

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's far better than enabling it in all cases IMO.
The added inline documentation is also very valuable so we know when these are enabled or disabled by default, and the user can make their own choice.

@ghys ghys merged commit b3a4318 into openhab:main May 7, 2023
@florian-h05 florian-h05 deleted the iconusestate-defaults branch May 7, 2023 13:24
@lolodomo
Copy link
Contributor

lolodomo commented May 7, 2023

For everyone, it is now enabled by default only for Contact', Dimmer, Rollershutter and Switch item types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants