Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MainUI] Update autocompletion for new MIME types #1619

Merged
merged 1 commit into from
Jan 3, 2023
Merged

[MainUI] Update autocompletion for new MIME types #1619

merged 1 commit into from
Jan 3, 2023

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Jan 1, 2023 •
edited
Loading

Reference openhab/openhab-addons#14013.
Reference openhab/openhab-addons#14096.

Signed-off-by: Florian Hotze [email protected]

@florian-h05 florian-h05 requested a review from a team as a code owner January 1, 2023 16:12
@relativeci
Copy link

relativeci bot commented Jan 1, 2023

Job #671: Bundle Size — 15.96MiB (+0.03%).

30ba6be(current) vs ae1e85a main#670(baseline)

Metrics (3 changes)
                 Current
Job #671		      Baseline
Job #670
Initial JS 1.73MiB 1.73MiB
Initial CSS 608.52KiB 608.52KiB
Cache Invalidation 90.47% 90.47%
Chunks 218 218
Assets 688 688
Modules 2007(-0.1%) 2009
Duplicate Modules 108 108
Duplicate Code 1.8%(+1.69%) 1.77%
Packages 133(-1.48%) 135
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #671		      Baseline
Job #670
CSS 856.56KiB 856.56KiB
Fonts 1.08MiB 1.08MiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.03MiB (+0.35%) 9MiB
Media 295.6KiB 295.6KiB
Other 4.59MiB (-0.58%) 4.61MiB

View job #671 report View main branch activity

@florian-h05
Copy link
Contributor Author

@ghys This is quite urgent because the UI currently provides a „swapped“ autocompletion because the MIME types changed.

@ghys ghys merged commit c2a52b5 into openhab:main Jan 3, 2023
@ghys ghys added bug Something isn't working main ui Main UI labels Jan 3, 2023
@ghys ghys added this to the 4.0 milestone Jan 3, 2023
@florian-h05 florian-h05 deleted the js-autocompletion-mime-types branch January 3, 2023 20:24
crnjan pushed a commit to crnjan/openhab-webui that referenced this pull request Jan 17, 2023
@florian-h05 @crnjan
[MainUI] Update autocompletion for new MIME types (openhab#1619)
cd08d80 
Reference openhab/openhab-addons#14013.
Reference openhab/openhab-addons#14096.

Signed-off-by: Florian Hotze <[email protected]>

Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Boris Krivonog <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@florian-h05 @ghys