Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cometvisu] Remove deprecated cometvisu-php binding #1594

Merged
merged 7 commits into from
Dec 30, 2022

Conversation

peuter
Copy link
Member

@peuter peuter commented Dec 19, 2022

closes #1592

Signed-off-by: Tobias Bräutigam [email protected]

@peuter peuter requested a review from a team as a code owner December 19, 2022 17:24
@kaikreuzer
Copy link
Member

Could you please rebase it on the latest main? There is a conflicting file.

@peuter peuter force-pushed the remove-cometvisu-php branch from fc875b3 to 8d6a677 Compare December 19, 2022 17:50
@kaikreuzer
Copy link
Member

Thanks - but please note that the build now fails...

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit 87e1d78 into openhab:main Dec 30, 2022
@kaikreuzer kaikreuzer added this to the 4.0 milestone Dec 30, 2022
@kaikreuzer kaikreuzer added the enhancement New feature or request label Dec 30, 2022
@kaikreuzer kaikreuzer changed the title remove deprecated cometvisu-php binding [cometvisu] Remove deprecated cometvisu-php binding Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cometvisu] Remove PHP support for CometVisu
3 participants