[mainui] Fix addons details serviceId

[J-N-K]

The serviceId for details page in the addon store was not properly determined if the addonId did not start with marketplace:.

[relativeci]

Job #253: Bundle Size — 10.75MB (~+0.01%).

56e0f9d vs 0a5c9e1

Changed metrics (0/8)

No changes

Changed assets by type (1/7)

	Current	Baseline
JS	8.47MB (~+0.01%)	8.47MB

No changes

---

View Job #253 report on app.relative-ci.com

[ghys]

You might want to address this problem too eventually:

openhab-webui/bundles/org.openhab.ui/web/src/components/addons/addon-info-table.vue

Line 50 in 9aeb301

value: (marketplace) ? 'Community Marketplace' : 'openHAB Distribution'

i.e. every add-on not coming from the marketplace will be advertised as coming from the openHAB distribution.
This was to avoid a call to /rest/addons/services to get the label. Though it might be sensible to do that:

• serviceId=marketplace => Source: Community Marketplace
• serviceId=karaf => Source: openHAB Distribution
• otherwise: use the Id as the source, or call /rest/addons/services and find out the label asynchronously.

If you want to postpone that to another PR I can accept this one in the meantime.

[J-N-K]

The question is how to fix that. I must admit that I have no idea how to do requests.

Of course it is easy to change it to indexOf(':') > 0 but that is not a proper fix either, because then other addon providers would identify as "Community Marketplace". If you think that is better, I'll happily update the PR. Another solution would be to distinguish between "community mp", "distribution", "other". This is possible without querying.

I did a quick check that the marketplace is used in three lines:

l. 50: to determine the "source"
l. 81: ?
l. 103: to add details like documentation.

l.50 could be changed to "Community Marketplace" (if starts with marketplace:), "openHAB Distribution" (if no prefix) and "Other" (if other prefix).
l. 103: a third case could be added, "documentation link" -> "addon.link".

Unfortunately I have no idea what l. 81 does. If you give me a hint, I can make the adjustments for this.

[J-N-K]

@ghys I tried to find a solution. WDYT?

[ghys]

LGTM - both the solution and the code.
Eventually the "3rd Party (serviceId)" could be improved with a request to get the real label but it's not that important right now.