Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix home page initialization logic #1177

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Fix home page initialization logic #1177

merged 2 commits into from
Oct 13, 2021

Conversation

ghys
Copy link
Member

@ghys ghys commented Oct 12, 2021

Regressions were introduced with #1055 where the state tracker wouldn't be started after going back to the home page from another page.
Also add a preloader which should only be displayed the first time.

Should fix #1161.

Signed-off-by: Yannick Schaus [email protected]

Regressions were introduced with openhab#1055 where the state tracker wouldn't be started after going back to the home page from another page.
Also add a preloader which should only be displayed the first time.

Should fix openhab#1161.

Signed-off-by: Yannick Schaus <[email protected]>
@ghys ghys requested a review from a team as a code owner October 12, 2021 18:17
@relativeci
Copy link

relativeci bot commented Oct 12, 2021

Job #225: Bundle Size — 10.65MB (~+0.01%).

20036d4 vs f1a9496

Changed metrics (2/8)
Metric Current Baseline
Initial JS 1.65MB(~+0.01%) 1.65MB
Cache Invalidation 15.62% 21.2%
Changed assets by type (1/7)
            Current     Baseline
JS 8.38MB (~+0.01%) 8.38MB

View Job #225 report on app.relative-ci.com

@ghys ghys added bug Something isn't working main ui Main UI labels Oct 13, 2021
@ghys ghys added this to the 3.2 milestone Oct 13, 2021
@ghys ghys merged commit ed06717 into openhab:main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cards in Main UI don’t show the item data (openHAB 3.1/3.2)
1 participant