-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct mimetype for disabling/enabling things call #1151
Conversation
Fixes openhab#1150 Signed-off-by: Stefan Triller <[email protected]>
I let @ghys review, I don't know why the media type is doubled. |
The first argument is the 'dataType', which is what you are expecting back from the server, the second is "contentType", the content type you are sending. See
|
bundles/org.openhab.ui/web/src/pages/settings/things/thing-details.vue
Outdated
Show resolved
Hide resolved
Signed-off-by: Stefan Triller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this!
Could you please also change it here (you can enable/disable multiple things at once from the list):
openhab-webui/bundles/org.openhab.ui/web/src/pages/settings/things/things-list.vue
Line 279 in cf9ae4a
const promises = this.selectedItems.map((i) => this.$oh.api.putPlain('/rest/things/' + i + '/enable', enable.toString(), 'application/json', 'application/json')) |
Signed-off-by: Stefan Triller <[email protected]>
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
Job #191: Bundle Size — 10.49MB (~-0.01%).Changed metrics (2/8)
|
Fixes #1150
Signed-off-by: Stefan Triller [email protected]