oh-icon component improvements, Iconify icon support #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the oh-icon to display both from more sources than the OH icon servlet; bundled Framework7/Material icons can also be displayed by this component (use `f7:` or `material:` prefixes). Specifying no prefix will assume an OH icon for backward compatibility. This also introduces Iconify (https://icon-sets.iconify.design) as an icon source, allowing access to 100,000+ icons from various icon sets, to display them in widgets like cards or floorplan markers. The Iconify option requires Internet connectivity on the client to access the external API but the underlying library will cache the icons in local/session storage to limit the requests and speed up the rendering. Update/fix documentation and plan marker default icon registration. Signed-off-by: Yannick Schaus <[email protected]>
Job #190: Bundle Size — 10.49MB (~-0.01%).Changed metrics (2/8)
|
Signed-off-by: Yannick Schaus <[email protected]>
|
@ghys Great job Yannick !! |
This was referenced Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the oh-icon to display icons from other sources than the
OH icon servlet; bundled Framework7/Material icons can also be displayed
by this component (use
f7:ormaterial:prefixes).Specifying no prefix will assume an OH icon for backward compatibility.
This also introduces Iconify (https://icon-sets.iconify.design) as an
icon source, allowing access to 100,000+ icons from various icon sets,
to display them in widgets like cards or floorplan markers.
The Iconify option requires Internet connectivity on the client to access
the external API but the underlying library will cache the icons in
local/session storage to limit the requests and speed up the rendering.
Update/fix documentation and plan marker default icon registration.
Closes #1081 (as the
mdiicon set is available though Iconify).Signed-off-by: Yannick Schaus [email protected]