Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade echarts to 5.1.2 #1099

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Conversation

crnjan
Copy link
Contributor

@crnjan crnjan commented Jun 9, 2021

When displaying two values using a single gauge, on initial load gauge(s) are not rendered correctly, as per screen:

switching a tab or similar action fixes the problem

After upgrade to 5.1.1. this cannot be reproduced anymore - a similar discussion here.

Signed-off-by: Boris Krivonog [email protected]

@crnjan crnjan requested a review from a team as a code owner June 9, 2021 12:44
@crnjan crnjan force-pushed the feature/echarts_upgrade_to_5_1_1 branch 2 times, most recently from 1ca194c to a0b1e3d Compare June 9, 2021 12:53
@relativeci
Copy link

relativeci bot commented Jun 9, 2021

Job #160: Bundle Size — 10.46MB (0%).

cc66639 vs cd5924d

No changes


View Job #160 report on app.relative-ci.com

@crnjan crnjan force-pushed the feature/echarts_upgrade_to_5_1_1 branch from a0b1e3d to 5cd1044 Compare June 9, 2021 13:06
@NorbertHD
Copy link

Why not v5.1.2 with even more fixes?

@crnjan
Copy link
Contributor Author

crnjan commented Jun 10, 2021

At the time I created my branch 5.1.2 did not yet exist :) Will update my PR ...

@crnjan crnjan changed the title Upgrade echarts to 5.1.1 Upgrade echarts to 5.1.2 Jun 10, 2021
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, there shouldn't be any regressions with this upgrade (I hope!).
Thanks!

@ghys ghys merged commit 551d26f into openhab:main Jun 10, 2021
@ghys ghys added this to the 3.1 milestone Jun 25, 2021
@ghys ghys added main ui Main UI enhancement New feature or request labels Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants