Fix analyzer back button if another popup was opened #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Framework7 would not consider an async route to be a modal route, leading to critical code not being executed and thus causing openhab#1068. This regression was introduced when the routes were changed to async in openhab#948. So introduce a new component and lazy load the analyzer inside it, so there's a minimal impact on the app entry point. Changed some z-indexes to make sure the popup backdrop is displayed between the analyzer popup and the item picker popup. Fixes openhab#1068. Fixes openhab#1067. Signed-off-by: Yannick Schaus <[email protected]>
Job #156: Bundle Size — 10.44MB (~-0.01%).Changed metrics (4/8)
Changed assets by type (2/7)
|
ghys
added a commit
to ghys/openhab-webui
that referenced
this pull request
Jun 24, 2021
Reverts the CSS z-index changes made in openhab#1095, without reinstating openhab#1067 & openhab#1068 because now analyzer route is now modal. There doesn't seem to be an easy way to insert the popup-backdrop between the item picker smart select popup (or model picker) and the analyzer popup/ analyzer controls sheet, especially if there's another popup _behind_ the analyzer popup with the `popup-behind` class. Fixes openhab#1105. Signed-off-by: Yannick Schaus <[email protected]>
ghys
added a commit
that referenced
this pull request
Jun 24, 2021
Reverts the CSS z-index changes made in #1095, without reinstating #1067 & #1068 because now the analyzer route is correctly modal. There doesn't seem to be an easy way to insert the popup-backdrop between the item picker smart select popup (or model picker) and the analyzer popup/analyzer controls sheet, especially if there's another popup _behind_ the analyzer popup with the `popup-behind` class. Fixes #1105. Signed-off-by: Yannick Schaus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Framework7 would not consider an async route to be a modal route,
leading to critical code not being executed and thus causing #1068.
This regression was introduced when the routes were changed to async in #948.
So introduce a new component and lazy load the analyzer inside it, so
there's a minimal impact on the app entry point.
Changed some z-indexes to make sure the popup backdrop is displayed between
the analyzer popup and the item picker popup.
Fixes #1068.
Fixes #1067.
Signed-off-by: Yannick Schaus [email protected]