Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link: fix profile selection #1093

Merged
merged 1 commit into from
Jun 6, 2021
Merged

Add link: fix profile selection #1093

merged 1 commit into from
Jun 6, 2021

Conversation

hubsif
Copy link
Contributor

@hubsif hubsif commented Jun 5, 2021

Fixes #1079

@hubsif hubsif requested a review from a team as a code owner June 5, 2021 18:05
@relativeci
Copy link

relativeci bot commented Jun 5, 2021

Job #154: Bundle Size — 10.44MB (~-0.01%).

757cdde vs 9f292f5

Changed metrics (1/8)
Metric Current Baseline
Cache Invalidation 2.62% 24.43%
Changed assets by type (1/7)
            Current     Baseline
JS 8.18MB (~-0.01%) 8.18MB

View Job #154 report on app.relative-ci.com

ghys
ghys approved these changes Jun 6, 2021
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, this seems to fix the profile selection indeed! Thanks

@ghys ghys merged commit 6f6da92 into openhab:main Jun 6, 2021
@ghys ghys changed the title Set current item from selected name Add link: fix profile selection Jun 6, 2021
@ghys ghys added bug Something isn't working main ui Main UI labels Jun 6, 2021
@ghys ghys added this to the 3.1 milestone Jun 6, 2021
crnjan pushed a commit to crnjan/openhab-webui that referenced this pull request Jun 9, 2021
@hubsif @crnjan
Set current item from selected name, fixes openhab#1079 (openhab#1093)
7723ef6 
Signed-off-by: Hubert Nusser <[email protected]>
Signed-off-by: Boris Krivonog <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

Cannot select profile when linking to an existing item
2 participants
@hubsif @ghys