Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Crowdin updates #1086

Merged
merged 7 commits into from
Jun 2, 2021
Merged

New Crowdin updates #1086

merged 7 commits into from
Jun 2, 2021

Conversation

openhab-bot
Copy link
Collaborator

No description provided.

@openhab-bot openhab-bot requested a review from a team as a code owner June 2, 2021 15:53
@relativeci
Copy link

relativeci bot commented Jun 2, 2021

Job #153: Bundle Size — 10.44MB (+0.27%).

9f292f5 vs 5de43fc

Changed metrics (3/8)
Metric Current Baseline
Initial JS 1.6MB(+0.48%) 1.6MB
Cache Invalidation 24.43% 0.17%
Modules 1478(+1.09%) 1462
Changed assets by type (1/7)
            Current     Baseline
JS 8.18MB (+0.34%) 8.15MB

View Job #153 report on app.relative-ci.com

@ghys
Copy link
Member

ghys commented Jun 2, 2021

The reason for this PR is I noticed the Hebrew translation isn't picked up by the i18n subsystem, so when you select Hebrew in Settings > Regional Settings > Language and save, things that should be translated remain in English (RTL support is another matter!).

It can be tracked to www.oracle.com/java/technologies/javase/jdk11-suported-locales.html
and https://bugs.java.com/bugdatabase/view_bug.do?bug_id=4140555
iw is the old ISO 639 code for Hebrew when Crowdin uses the new one, he.

Browsers still accept both, this is why the date below the title on the home page was in Hebrew, but vue-i18n does not. Apparently Java also has similar mechanisms, so it might or might not be a concern for @openhab/core-maintainers.

Anyways, I added a language mapping so the Hebrew now generate iw.json which will be properly recognized by vue-i18n:

image

@ghys ghys merged commit 4194cd2 into main Jun 2, 2021
@openhab-bot openhab-bot deleted the l10n-crowdin branch June 2, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants