Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for multimedia badges #1074

Merged
merged 1 commit into from
May 30, 2021
Merged

Improvements for multimedia badges #1074

merged 1 commit into from
May 30, 2021

Conversation

cweitkamp
Copy link
Contributor

  • Improvements for multimedia badges: added VoiceAssistant for speakers, consider PLAY, FASTFORWARD and REWIND for displaying the badge

Signed-off-by: Christoph Weitkamp [email protected]

@cweitkamp
Improvements for multimedia badges
6c56798 
Signed-off-by: Christoph Weitkamp <[email protected]>
@cweitkamp cweitkamp requested a review from a team as a code owner May 30, 2021 08:46
@relativeci
Copy link

relativeci bot commented May 30, 2021

Job #141: Bundle Size — 10.41MB (~+0.01%).

fcfbdd8 vs 45d01fa

Changed metrics (2/8)
Metric Current Baseline
Initial JS 1.6MB(+0.01%) 1.6MB
Cache Invalidation 21.26% 3.4%
Changed assets by type (1/7)
            Current     Baseline
JS 8.15MB (~+0.01%) 8.15MB

View Job #141 report on app.relative-ci.com

ghys
ghys approved these changes May 30, 2021
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghys ghys merged commit df053b9 into openhab:main May 30, 2021
@ghys ghys added this to the 3.1 milestone May 30, 2021
@ghys ghys added enhancement New feature or request main ui Main UI labels May 30, 2021
@cweitkamp cweitkamp deleted the feature-multimedia-badges branch May 30, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@cweitkamp @ghys