Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix height description in grid layout properties #1023

Merged
merged 2 commits into from
May 9, 2021
Merged

Fix height description in grid layout properties #1023

merged 2 commits into from
May 9, 2021

Conversation

eikowagenknecht
Copy link
Contributor

Just a quick fix of a copy/paste error.

Signed-off-by: Eiko Wagenknecht [email protected]

@eikowagenknecht eikowagenknecht requested a review from a team as a code owner April 26, 2021 09:08
@relativeci
Copy link

relativeci bot commented Apr 26, 2021

Job #104: Bundle Size — 10.46MB (0%).

07333da vs 1f56adf

Changed metrics (1/8)
Metric Current Baseline
Cache Invalidation 0.18% 22.75%
Changed assets by type (0/7)

No changes


View Job #104 report on app.relative-ci.com

@ghys
Copy link
Member

ghys commented Apr 27, 2021

Thanks, could you run node generate.js in doc/components/src as well to update the documentation page? (commit only the doc/components/oh-grid-layout.md file. If it doesn't work you may update it manually as the change is small.)

@eikowagenknecht
Copy link
Contributor Author

Sure, it's done. I noticed there are some differences in oh-cell, oh-label-card and oh-label-cell as well after generating the docs, maybe those were forgotten somewhere else?

image

@ghys
Copy link
Member

ghys commented Apr 30, 2021

This is a result of #993 not being complete as it changed the fix for the oh-trend component but not those which include a trend line and therefore inherit its parameters.
If you still have those around, I'd be grateful if you could commit these as well as part of this PR.

Signed-off-by: Eiko Wagenknecht <[email protected]>
@eikowagenknecht
Copy link
Contributor Author

Sure, I made it a second commit in this PR because it's another issue, hope that's allright.

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, much appreciated!
The Jenkins build failure is not related to this PR.

@ghys ghys merged commit 37cb636 into openhab:main May 9, 2021
@eikowagenknecht eikowagenknecht deleted the pull-label branch May 18, 2021 09:30
@ghys ghys added this to the 3.1 milestone May 30, 2021
@ghys ghys added main ui Main UI bug Something isn't working labels May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants