Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Assistant: Rework metadata UI - Part 2 #1020

Merged
merged 1 commit into from
Apr 25, 2021
Merged

Google Assistant: Rework metadata UI - Part 2 #1020

merged 1 commit into from
Apr 25, 2021

Conversation

eikowagenknecht
Copy link
Contributor

Sorry, I missed some things in the first PR you merged today.

  • Added some more description text
  • Moved some text from title to description where everything was crammed in the title
  • Made URLs work as links
  • Split the list in two option groups (like the Alexa metadata UI does, code is mainly from there):

image

@eikowagenknecht eikowagenknecht requested a review from a team as a code owner April 25, 2021 16:13
@relativeci
Copy link

relativeci bot commented Apr 25, 2021 •
edited
Loading

Job #91: Bundle Size — 10.46MB (~-0.01%).

1644b04 vs 8fe0d04

Changed metrics (1/8)
Metric Current Baseline
Cache Invalidation 2.6% 2.59%
Changed assets by type (1/7)
            Current     Baseline
JS 8.12MB (~-0.01%) 8.12MB

View Job #91 report on app.relative-ci.com

@eikowagenknecht
Rework metadata UI for new GA binding - Part 2
810e695 
Signed-off-by: Eiko Wagenknecht <[email protected]>
(cherry picked from commit a2abc1d)
ghys
ghys approved these changes Apr 25, 2021
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Code looks good, I don't use GA so cannot comment on the functionality but will trust you on that.

@ghys ghys merged commit 4f94d26 into openhab:main Apr 25, 2021
@eikowagenknecht eikowagenknecht deleted the pull-ga2 branch April 25, 2021 20:45
hubsif pushed a commit to hubsif/openhab-webui that referenced this pull request May 6, 2021
@eikowagenknecht @hubsif
Rework metadata UI for new GA binding - Part 2 (openhab#1020)
074edc1 
Signed-off-by: Eiko Wagenknecht <[email protected]>
@ghys ghys added this to the 3.1 milestone May 30, 2021
@ghys ghys added main ui Main UI enhancement New feature or request labels May 30, 2021
@ghys ghys changed the title Rework metadata UI for new GA binding - Part 2 Google Assistant: Rework metadata UI - Part 2 May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@eikowagenknecht @ghys