Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display error at tech info on iOS, fixes #849 #1016

Merged
merged 1 commit into from
Apr 25, 2021
Merged

Conversation

hubsif
Copy link
Contributor

@hubsif hubsif commented Apr 25, 2021

Replaced the f7-toolbar by a f7-navbar (looks exactly the same, but respects the safe area). Additionally removed the f7-page, as I think it's not required (and should not be used in popup).

@hubsif hubsif requested a review from a team as a code owner April 25, 2021 08:56
@relativeci
Copy link

relativeci bot commented Apr 25, 2021

Job #86: Bundle Size — 10.45MB (-0.27%).

929ec38 vs c16ce4d

Changed metrics (3/8)
Metric Current Baseline
Initial JS 1.61MB(-0.32%) 1.61MB
Cache Invalidation 22.73% 22.52%
Modules 1442(-0.76%) 1453
Changed assets by type (1/7)
            Current     Baseline
JS 8.12MB (-0.34%) 8.15MB

View Job #86 report on app.relative-ci.com

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghys ghys merged commit fa4690f into openhab:main Apr 25, 2021
@hubsif hubsif deleted the fix_849 branch April 30, 2021 17:38
hubsif added a commit to hubsif/openhab-webui that referenced this pull request May 6, 2021
@ghys ghys added this to the 3.1 milestone May 30, 2021
@ghys ghys added main ui Main UI bug Something isn't working labels May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants