Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MainUI] Add widget metadata to item results in missing selection of widget #766

Closed
kuifje123 opened this issue Jan 6, 2021 · 11 comments · Fixed by #768 or #787
Closed

[MainUI] Add widget metadata to item results in missing selection of widget #766

kuifje123 opened this issue Jan 6, 2021 · 11 comments · Fixed by #768 or #787
Assignees
Labels
bug Something isn't working main ui Main UI

Comments

@kuifje123
Copy link

kuifje123 commented Jan 6, 2021

The problem

Using OH3 #2115 I notice that adding widget metadata to an item results in an empty page.

Expected behavior

On previous builds I was able to select the widget. This selection is now missing.

Steps to reproduce

Tested with various different items. All with same result.

Your environment

runtimeInfo:
version: 3.1.0
buildString: "Build #2115"
locale: en_NL
systemInfo:
configFolder: /openhab/conf
userdataFolder: /openhab/userdata
logFolder: /openhab/userdata/logs
javaVersion: 11.0.9
javaVendor: Azul Systems, Inc.
javaVendorVersion: Zulu11.43+21-CA
osName: Linux
osVersion: 4.4.59+
osArchitecture: amd64
availableProcessors: 1
freeMemory: 124337888
totalMemory: 346030080
bindings:

  • astro
  • exec
  • harmonyhub
  • http
  • icloud
  • irobot
  • mqtt
  • network
  • ntp
  • openweathermap
  • tr064
  • zwave
    clientInfo:
    device:
    ios: true
    android: false
    androidChrome: false
    desktop: false
    iphone: false
    ipod: false
    ipad: true
    edge: false
    ie: false
    firefox: false
    macos: false
    windows: false
    cordova: false
    phonegap: false
    electron: false
    nwjs: false
    os: ios
    osVersion: 14.0.1
    webView: true
    webview: true
    standalone: true
    pixelRatio: 2
    prefersColorScheme: dark
    isSecureContext: false
    locationbarVisible: true
    menubarVisible: true
    navigator:
    cookieEnabled: true
    deviceMemory: N/A
    hardwareConcurrency: N/A
    language: en-gb
    languages:
    • en-gb
      onLine: true
      platform: MacIntel
      screen:
      width: 834
      height: 1112
      colorDepth: 32
      support:
      touch: true
      pointerEvents: true
      observer: true
      passiveListener: true
      gestures: true
      intersectionObserver: true
      themeOptions:
      dark: dark
      filled: true
      pageTransitionAnimation: default
      bars: light
      homeNavbar: default
      homeBackground: default
      expandableCardAnimation: default
      userAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15
      (KHTML, like Gecko) Version/14.0.1 Safari/605.1.15
      timestamp: 2021-01-06T21:04:01.323Z

Browser console

Warning processing windowTypes: This property is deprecated global.min.js:250
makeError resource://gre/modules/Schemas.jsm:518
logWarning resource://gre/modules/Schemas.jsm:1230
logDeprecation resource://gre/modules/Schemas.jsm:1222
checkDeprecated resource://gre/modules/Schemas.jsm:1258
normalizeBase resource://gre/modules/Schemas.jsm:1381
normalize resource://gre/modules/Schemas.jsm:2212
r resource://gre/modules/Schemas.jsm:1906
withPath resource://gre/modules/Schemas.jsm:603
checkProperty resource://gre/modules/Schemas.jsm:1905
normalize resource://gre/modules/Schemas.jsm:1978
normalize resource://gre/modules/Schemas.jsm:1514
fixedArgs resource://gre/modules/Schemas.jsm:2571
map self-hosted:221
checkParameters resource://gre/modules/Schemas.jsm:2566
stub resource://gre/modules/Schemas.jsm:2672
a moz-extension://91accb6c-4650-4a01-8e30-128fda0dd962/global.min.js:250
apply self-hosted:2644
applySafeWithoutClone resource://gre/modules/ExtensionCommon.jsm:616
fire resource://gre/modules/ExtensionChild.jsm:806
recvRunListener resource://gre/modules/ExtensionChild.jsm:810
recvRunListener self-hosted:1161
_recv resource://gre/modules/ConduitsChild.jsm:78
receiveMessage resource://gre/modules/ConduitsChild.jsm:184
(Async: JSActor query)
_send resource://gre/modules/ConduitsChild.jsm:61
_send resource://gre/modules/ConduitsParent.jsm:228
_send self-hosted:1265
listener resource://gre/modules/ExtensionParent.jsm:1001
apply self-hosted:2644
applySafeWithoutClone resource://gre/modules/ExtensionCommon.jsm:616
applySafe resource://gre/modules/ExtensionParent.jsm:508
async resource://gre/modules/ExtensionCommon.jsm:2413
(Async: promise callback)
async resource://gre/modules/ExtensionCommon.jsm:2411
listener chrome://browser/content/parent/ext-windows.js:102
(Async: promise callback)
listener chrome://browser/content/parent/ext-windows.js:92

Browser network traffic

network

Additional information

@kuifje123 kuifje123 added bug Something isn't working main ui Main UI labels Jan 6, 2021
@kuifje123
Copy link
Author

kuifje123 commented Jan 6, 2021

EE324597-782D-4931-BBEC-38B77E832427
BD049F70-D6BD-4CC6-8D13-C505F3B2217E
4E9C0390-086E-4F99-A0DA-5A2ACE6760D0
7B3840E4-EF49-4995-8518-0E29AAB0D348

@kuifje123 kuifje123 changed the title [MainUI] Add widge metadata to item results in missing selection of widget [MainUI] Add widget metadata to item results in missing selection of widget Jan 6, 2021
@ghys
Copy link
Member

ghys commented Jan 8, 2021

Browser console

Browser network traffic

@kuifje123
Copy link
Author

Hi @ghys I added these in the issue above.
I hope it will help.
If there are additional things I can test, let me know.

@ghys
Copy link
Member

ghys commented Jan 8, 2021

The console output above doesn't look like the app's, but a browser extension.
Can you try again in Chrome or equivalent, in incognito mode, also paste the contents of the response of the network request that ends with "? metadata=widget". Thanks.

@kuifje123
Copy link
Author

Chrome console output:

app.js:7 ReferenceError: $store is not defined
at orderedPersonalWidgets (20.app.js:1)
at fn.get (app.js:7)
at fn.evaluate (app.js:7)
at o.orderedPersonalWidgets (app.js:7)
at o. (20.app.js:1)
at o.e._render (app.js:7)
at o.a (app.js:7)
at fn.get (app.js:7)
at fn.run (app.js:7)
at pn (app.js:7)
Ge @ app.js:7
We @ app.js:7
Ue @ app.js:7
e._render @ app.js:7
a @ app.js:7
fn.get @ app.js:7
fn.run @ app.js:7
pn @ app.js:7
(anonymous) @ app.js:7
Qe @ app.js:7
Promise.then (async)
Ye @ app.js:7
at @ app.js:7
(anonymous) @ app.js:7
fn.update @ app.js:7
pe.notify @ app.js:7
set @ app.js:7
mn.set @ app.js:7
(anonymous) @ 20.app.js:1
Promise.then (async)
onPageAfterIn @ 20.app.js:1
qe @ app.js:7
n @ app.js:7
qe @ app.js:7
e.$emit @ app.js:7
(anonymous) @ app.js:7
t.a @ app.js:7
dispatchEvent @ app.js:20
onPageAfterIn @ app.js:20
(anonymous) @ app.js:9
(anonymous) @ app.js:9
value @ app.js:9
(anonymous) @ app.js:9
value @ app.js:9
(anonymous) @ app.js:9
value @ app.js:9
value @ app.js:9
U @ app.js:9
(anonymous) @ app.js:9
(anonymous) @ app.js:9
r @ app.js:1
c @ app.js:1

@kuifje123
Copy link
Author

kuifje123 commented Jan 8, 2021

Network response:

http://diskstation918.fritz.box:8080/rest/items/TSV_BedroomN_Setpoint?metadata=widget

{"link":"http://diskstation918.fritz.box:8080/rest/items/TSV_BedroomN_Setpoint","state":"18 °C","stateDescription":{"pattern":"%.0f","readOnly":false,"options":[]},"editable":true,"type":"Number:Temperature","name":"TSV_BedroomN_Setpoint","label":"Slaapkamer Niels Setpoint","category":"heating","tags":["RadiatorControl"],"groupNames":[]}

@ghys ghys self-assigned this Jan 8, 2021
ghys added a commit to ghys/openhab-webui that referenced this issue Jan 8, 2021
Fixes openhab#766.

Signed-off-by: Yannick Schaus <[email protected]>
@ghys
Copy link
Member

ghys commented Jan 8, 2021

Wow, serious lack of testing of #724...
That's what happens when you review PRs on your phone during the holidays...
#768 should fix it, thanks for the report!

@kuifje123
Copy link
Author

Thanks for the quick fix 👍

@ghys ghys closed this as completed in #768 Jan 8, 2021
ghys added a commit that referenced this issue Jan 8, 2021
Fixes #766.

Signed-off-by: Yannick Schaus <[email protected]>
@johannesbonn
Copy link

Hello @ghys,

can you tell me, when the fix will be available in the snapshots?

thank you!

@kuifje123
Copy link
Author

@ghys
Just installed snapshot 2131, this issue does not appear to be solved yet, is that correct?

@ghys
Copy link
Member

ghys commented Jan 11, 2021

Hm, yes indeed there's still a problem, sorry for that.

ghys added a commit to ghys/openhab-webui that referenced this issue Jan 11, 2021
Fixes openhab#766 (second attempt).

Signed-off-by: Yannick Schaus <[email protected]>
ghys added a commit that referenced this issue Jan 11, 2021
Fixes #766 (second attempt).

Signed-off-by: Yannick Schaus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
3 participants