Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MainUI] [OH3] Remove button should not be shown in MainUI for Items from files #694

Closed
eikowagenknecht opened this issue Dec 23, 2020 · 1 comment · Fixed by #774
Closed

[MainUI] [OH3] Remove button should not be shown in MainUI for Items from files #694

eikowagenknecht opened this issue Dec 23, 2020 · 1 comment · Fixed by #774
Assignees
@ghys
Labels
bug Something isn't working main ui Main UI

Comments

@eikowagenknecht
Copy link
Contributor

The problem

Items defined in .items file still show a "Remove" button in the Semantic Model:
image

Clicking on it leads to the error message:
image

Expected behavior

Since removing Items from .items file is not possible in the MainUI the button should not be shown (or greyed out). If this is not possible, at least the error message should be more specific like "Can not remove items that are defined in .items files."
@eikowagenknecht eikowagenknecht added bug Something isn't working main ui Main UI labels Dec 23, 2020
@ghys ghys self-assigned this Jan 8, 2021
ghys added a commit to ghys/openhab-webui that referenced this issue Jan 8, 2021
@ghys
Don't show edit/save buttons in model if item is not editable
927db2a 
Fixes openhab#694.

Signed-off-by: Yannick Schaus <[email protected]>
@ghys ghys mentioned this issue Jan 8, 2021
Merged
@ghys ghys closed this as completed in #774 Jan 8, 2021
ghys added a commit that referenced this issue Jan 8, 2021
@ghys
Don't show edit/save buttons in model if item is not editable (#774)
60063d2 
Fixes #694.

Signed-off-by: Yannick Schaus <[email protected]>
@eikowagenknecht
Copy link
Contributor Author

Thanks!

ghys added a commit to ghys/openhab-webui that referenced this issue Jan 11, 2021
@ghys
Don't show edit/save buttons in model if item is not editable (openha…
5a6f47f 
…b#774)

Fixes openhab#694.

Signed-off-by: Yannick Schaus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghys ghys

Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't show edit/save buttons in model if item is not editable ghys/openhab-webui
2 participants
@eikowagenknecht @ghys