[MainUI] Inbox / add as thing: let the user decide the thing id

[lolodomo]

When you add an inbox entry as thing, the pop-up propose to edit the thing label. It would be cool to have a way to edit the thing id (last part of the thing UID) too because it is something no more editable later.

[ghys]

Agreed, but it's not really a "webui" problem since the /rest/inbox/{thingUID}/approve API only lets you approve inbox entries where the thing ID has been already decided. I suggest moving it to core to propose a change to the API.

[lolodomo]

Ok with your suggestion ;)

[lolodomo]

@ghys : can you please reopen this issue.
I have implemented the feature on core side: openhab/openhab-core#1848

[lolodomo]

Change in core is now merged.
@ghys : it would be super now if the MainUI could be enhanced to provide a new field in the popup to enter an optional thing id.

[ghys]

Okay, there's no dialog with 2 text fields available so there will be a need for a completely redesigned UI to approve.

[ghys]

Adding the question label until the problem with the API is fixed (see openhab/openhab-core#1848 (comment))

[lolodomo]

@ghys : API is now fixed in core framework (PR merged).

[lolodomo]

@ghys : I don't understand how it was enhanced.
Here is the dialog box when I add a thing for the inbox:

As before, I have a control only on the label but not on the thing id.

OH3 snapshot 2131:

openhab> bundle:list -s | grep ui
 83 x Active x  80 x 3.10.400.v20190516-1504 x org.eclipse.equinox.common
160 x Active x  80 x 3.1.0.202101100957      x org.openhab.core.io.rest.ui
190 x Active x  80 x 3.1.0.202101100956      x org.openhab.core.ui
191 x Active x  80 x 3.1.0.202101100957      x org.openhab.core.ui.icon
193 x Active x  80 x 3.1.0.202101100100      x org.openhab.ui
241 x Active x  80 x 3.1.0.202101100057      x org.openhab.ui.basic
242 x Active x  80 x 3.1.0.202101100057      x org.openhab.ui.iconset.classic

[ghys]

When you click on a thing and get the menu you should have a new "Add as Thing (with custom ID)" option, if not that might be a cache problem, go to Help & About and select the purge caches option if you have it, otherwise Reload app.

[lolodomo]

Oh yes, I see the menu on my phone.
I will try to understand why the menu is not displayed on my PC while I cleared the
WEB browser cache.

[lolodomo]

@ghys : I know what is happening. Your menu is OK in the "Inbox" page. The problem is that this menu is not proposed in the "Add a new Thing xxxxxx" page.
There is a workaround, I just have to return to the inbox page before adding my thing. But this is something usual to search a thing and to add it directly from the "add a new thing" page.

[lolodomo]

In fact, I am just discovering again my feature request #416 ;)

[ghys]

I didn't forget about #416, I regularly check issue lists, and it will probably come in conjunction with it when/if it gets implemented.
#775 was mostly about fixing #744 to include it as part of the 3.0.1 patch release, I just added it because it was safe to add and in the same file :)