-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BasicUI] Problem with image element being root of another page => no access to the sub page #2233
Comments
I tried to reproduce your case with this sitemap but I can't, clicking on the images I went to the sub page as expected.
|
@JensHoRi : I can't reproduce. Can you search what is different from your sitemap and mine ? |
Ok, interesting, I can reproduce your problem using Chrome or Edge. |
I see the same problem with OH3.4.4 and OH 4.0.4. So this is not something new. |
@JensHoRi : was it working for you in a certain version of openHAB ? If yes, in which one ? |
We even do not need image item, just an image element with URL shows the issue in Chrome and Edge:
ir with this one:
|
Well, I have an image directly in the item (open weather binding stores that way) but that’s the only difference. Got the problem in all browsers including Firefox |
Strange, it works for me in Firefox. Please replace in your sitemap "Image label="Grafik" item=owmCurrentConditionIcon {" by "Image url="https://www.openhab.org/openhab-logo-square.png" {" and tell me if you still encounter a problem with Firefox. |
After clearing my Firefox cache, I have the same problem with Firefox ! |
I have not yet any idea why it does not work in OH versions < 4.1 but I know why it does not work in OH 4.1, this is due to the new header row I introduced for image element which should be ignored for image elements being the trigger of a sub page. I am very probably crashing the JavaScript script at least at this line: |
With 4.0.x I didn’t had this issue. I updated very often, every stable version edit: just looked on my update path: Entpacken von openhab (4.1.0-1) über (4.0.4-2) so 4.0.4-2 was earlier version without this issue. Crazy that all following subpages failing too… |
Strange because I can reproduce it easily. |
I'm no developer, but just looked in Firefox analyzing the item: Have no idea where this code is build. Looked your earlier post, but confused with the brackets what to test: |
Fix openhab#2233 Signed-off-by: Laurent Garnier <[email protected]>
Fix #2233 Signed-off-by: Laurent Garnier <[email protected]>
Fix #2233 Signed-off-by: Laurent Garnier <[email protected]>
Updated yesterday to last version openhab (4.1.0-1) from earlier Version 4.0.x i believe.
I have a Subpage could be entered with an Image item worked before, now breaking the sitemap.
Here an example (be aware, you need an imageitem, an item called Empty (String in my case) and a group for testing:
The text was updated successfully, but these errors were encountered: