We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playing with heating widget and trying to use iconify icons - so replacing f7-icon with a oh-icon - the icon(s) were not displayed.
f7-icon
oh-icon
It turns out the problem is related to the style property and how it's applied.
style
One should be able to use custom style with oh-icon.
component: f7-card config: title: TEST slots: default: - component: oh-icon config: height: 28px icon: iconify:mdi:fan-speed-3 style: position: absolute top: 5px left: 55px
will render
ignoring the content within style. As far as I can see from code style is only (fully) applied for oh icons, while not for others:
oh
component: f7-card config: title: TEST slots: default: - component: oh-icon config: height: 28px icon: oh:light style: position: absolute top: 5px left: 55px
since style is applied to underlying img, while not for other two (f7-icon and iconify-icon).
img
iconify-icon
Wrapping oh-icon in another block "fixes" the issue:
component: f7-card config: title: TEST slots: default: - component: f7-block config: style: position: absolute top: 5px left: 55px slots: default: - component: oh-icon config: height: 28px icon: iconify:mdi:fan-speed-3
renders:
IMHO other sections of report are not needed therefore removed them, but please let me know if there is any more info needed from my side.
The text was updated successfully, but these errors were encountered:
Add missing style parameter to oh-icon
b2f18e7
Fixes openhab#1183. Signed-off-by: Yannick Schaus <[email protected]>
Add missing style parameter to oh-icon (#1233)
a482051
Fixes #1183. Signed-off-by: Yannick Schaus <[email protected]>
Check config before allowing oh-icon style customization (#1243)
abb43cf
Fixes #1242. Checking that the oh-icon has a config set is enough to solve both #1242 and #1183. Signed-off-by: Yannick Schaus <[email protected]>
ghys
Successfully merging a pull request may close this issue.
The problem
Playing with heating widget and trying to use iconify icons - so replacing
f7-icon
with aoh-icon
- the icon(s) were not displayed.It turns out the problem is related to the
style
property and how it's applied.Expected behavior
One should be able to use custom
style
withoh-icon
.Steps to reproduce
will render
ignoring the content within
style
. As far as I can see from codestyle
is only (fully) applied foroh
icons, while not for others:will render
since
style
is applied to underlyingimg
, while not for other two (f7-icon
andiconify-icon
).Additional Info
Wrapping
oh-icon
in another block "fixes" the issue:renders:
IMHO other sections of report are not needed therefore removed them, but please let me know if there is any more info needed from my side.
The text was updated successfully, but these errors were encountered: