Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metOfficeDataHub] logo addition #2409

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Conversation

dag81
Copy link
Contributor

@dag81 dag81 commented Nov 17, 2024

Addition of logo for new metofficedatahub binding, this is for the representation of this binding covered in this PR: openhab/openhab-addons#15367

[metOfficeDataHub] logo addition

Signed-off-by: dag81 <[email protected]>
Copy link

netlify bot commented Nov 17, 2024

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Built without sensitive environment variables

Name Link
🔨 Latest commit f83e6af
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/6748f21f920206000894fc21
😎 Deploy Preview https://deploy-preview-2409--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dag81
Copy link
Contributor Author

dag81 commented Nov 21, 2024

Changing to non-draft - so its ready after the binding is merged.

@dag81 dag81 marked this pull request as ready for review November 21, 2024 23:20
Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove a bit of the margin around the logo?

dag81 and others added 2 commits November 28, 2024 22:43
@dag81 dag81 requested a review from stefan-hoehn November 28, 2024 22:52
Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Looks good to me.

@stefan-hoehn stefan-hoehn added this to the 4.3 milestone Nov 29, 2024
@stefan-hoehn stefan-hoehn merged commit c83c2e2 into openhab:main Nov 29, 2024
5 checks passed
@dag81
Copy link
Contributor Author

dag81 commented Nov 29, 2024

@stefan-hoehn Thank you for the quick merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants