Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitemap] Extended period attribute for chart to cover past and future #2284

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

lolodomo
Copy link
Contributor

Related to openhab/openhab-webui#2518

Signed-off-by: Laurent Garnier [email protected]

Copy link

netlify bot commented Apr 14, 2024

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Built without sensitive environment variables

Name Link
🔨 Latest commit bafc398
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/661baeafb3ca370008870bdb
😎 Deploy Preview https://deploy-preview-2284--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, thanks
(and I learned a lot about ISO8601 periods as well which was new to me 👏🏻)

@stefan-hoehn stefan-hoehn added this to the 4.2 milestone Apr 19, 2024
@stefan-hoehn stefan-hoehn merged commit 817bdab into openhab:main Apr 19, 2024
4 checks passed
@lolodomo lolodomo deleted the sitemap_chart_period branch April 19, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants