-
-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Voice] Add build-it interpreter doc and fix dialog commands #2200
Conversation
Signed-off-by: Miguel Álvarez <[email protected]>
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).
To edit notification comments on pull requests, go to your Netlify site configuration. |
I would like to move voice documentation to its own page outside of multimedia. Is that ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comprehensive contribution. See my review comments.
Signed-off-by: Miguel Álvarez <[email protected]>
Signed-off-by: Miguel Álvarez <[email protected]>
I have applied all the suggestions I have left one open to know if the rephrase is good enough. For the record all the functionality is already in the 4.1.0 version, I don't know if the documentation is updated on path releases but just in case. Thank you for the review! |
I have marked as 4.1 then. Thanks for letting me know. |
Signed-off-by: Miguel Álvarez <[email protected]>
You are welcome, I should have it mentioned on the description. I have applied the last comment. |
@GiviMAD this is still not fixed
|
Signed-off-by: Miguel Álvarez <[email protected]>
Oh sorry, I hadn't seen it. Thank for pinging me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally we're done. Thanks for the contribution.
configuration/multimedia.md
Outdated
|
||
#### Exact match label/synonym prevalence | ||
|
||
Another way you can solve this is by using the exact match prevalence, Items whose label/synonym matches the one in the command exactly take prevalence. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I found another typo, sorry:
Items whose label/synonym matches the one -> match
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GiviMAD Did you see this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…#2200) * [Voice] Add build-it interpreter doc and fix dialog commands Signed-off-by: Miguel Álvarez <[email protected]> * apply pr review Signed-off-by: Miguel Álvarez <[email protected]> * apply pr review Signed-off-by: Miguel Álvarez <[email protected]> * apply pr review Signed-off-by: Miguel Álvarez <[email protected]> * apply pr review Signed-off-by: Miguel Álvarez <[email protected]> --------- Signed-off-by: Miguel Álvarez <[email protected]>
I have a small documentation for the built-it interpreter (StandardInterpreter in the code).
Also I have fixed the dialog console commands.