Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Voice] Add build-it interpreter doc and fix dialog commands #2200

Merged
merged 5 commits into from
Jan 13, 2024

Conversation

GiviMAD
Copy link
Member

@GiviMAD GiviMAD commented Jan 5, 2024

I have a small documentation for the built-it interpreter (StandardInterpreter in the code).

Also I have fixed the dialog console commands.

Copy link

netlify bot commented Jan 5, 2024

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit 17e38ee
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/65a05cb12048420008d26956
😎 Deploy Preview https://deploy-preview-2200--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@GiviMAD
Copy link
Member Author

GiviMAD commented Jan 5, 2024

I would like to move voice documentation to its own page outside of multimedia. Is that ok?

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comprehensive contribution. See my review comments.

configuration/multimedia.md Outdated Show resolved Hide resolved
configuration/multimedia.md Outdated Show resolved Hide resolved
configuration/multimedia.md Outdated Show resolved Hide resolved
configuration/multimedia.md Outdated Show resolved Hide resolved
configuration/multimedia.md Outdated Show resolved Hide resolved
configuration/multimedia.md Outdated Show resolved Hide resolved
configuration/multimedia.md Outdated Show resolved Hide resolved
configuration/multimedia.md Outdated Show resolved Hide resolved
configuration/multimedia.md Outdated Show resolved Hide resolved
configuration/multimedia.md Outdated Show resolved Hide resolved
@stefan-hoehn stefan-hoehn added this to the 4.2 milestone Jan 5, 2024
Signed-off-by: Miguel Álvarez <[email protected]>
Signed-off-by: Miguel Álvarez <[email protected]>
@GiviMAD
Copy link
Member Author

GiviMAD commented Jan 5, 2024

I have applied all the suggestions I have left one open to know if the rephrase is good enough.

For the record all the functionality is already in the 4.1.0 version, I don't know if the documentation is updated on path releases but just in case.

Thank you for the review!

@GiviMAD GiviMAD requested a review from stefan-hoehn January 5, 2024 12:20
@stefan-hoehn stefan-hoehn modified the milestones: 4.2, 4.1 Jan 5, 2024
@stefan-hoehn
Copy link
Contributor

For the record all the functionality is already in the 4.1.0 version

I have marked as 4.1 then. Thanks for letting me know.

Signed-off-by: Miguel Álvarez <[email protected]>
@GiviMAD
Copy link
Member Author

GiviMAD commented Jan 5, 2024

I have marked as 4.1 then. Thanks for letting me know.

You are welcome, I should have it mentioned on the description.

I have applied the last comment.

@stefan-hoehn
Copy link
Contributor

@GiviMAD this is still not fixed

Another way you can solve this is by using the exact match prevalence, Items whose label/synonym matches the one in the command exactly take prevalence.

Signed-off-by: Miguel Álvarez <[email protected]>
@GiviMAD
Copy link
Member Author

GiviMAD commented Jan 11, 2024

@GiviMAD this is still not fixed

Another way you can solve this is by using the exact match prevalence, Items whose label/synonym matches the one in the command exactly take prevalence.

Oh sorry, I hadn't seen it. Thank for pinging me.

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally we're done. Thanks for the contribution.


#### Exact match label/synonym prevalence

Another way you can solve this is by using the exact match prevalence, Items whose label/synonym matches the one in the command exactly take prevalence.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I found another typo, sorry:

Items whose label/synonym matches the one -> match

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GiviMAD Did you see this one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GiviMAD Did you see this one?

:/ sorry again for missing it.

And thank you for the review!

@stefan-hoehn stefan-hoehn modified the milestones: 4.1, 4.2 Jan 13, 2024
@stefan-hoehn stefan-hoehn merged commit 88a862f into openhab:main Jan 13, 2024
5 checks passed
pgfeller pushed a commit to pgfeller/openhab-docs that referenced this pull request Jan 15, 2024
…#2200)

* [Voice] Add build-it interpreter doc and fix dialog commands

Signed-off-by: Miguel Álvarez <[email protected]>

* apply pr review

Signed-off-by: Miguel Álvarez <[email protected]>

* apply pr review

Signed-off-by: Miguel Álvarez <[email protected]>

* apply pr review

Signed-off-by: Miguel Álvarez <[email protected]>

* apply pr review

Signed-off-by: Miguel Álvarez <[email protected]>

---------

Signed-off-by: Miguel Álvarez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants