-
-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sitemap: extended syntax for icon to define conditional rules #2175
Conversation
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).
To edit notification comments on pull requests, go to your Netlify site configuration. |
Related to openhab/openhab-core#3820 Signed-off-by: Laurent Garnier <[email protected]>
ccf4d17
to
10792c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comprehensive documentation.
A small type in openHAB and a minor unclear sentence (at least to me)
Signed-off-by: Laurent Garnier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx, @lolodomo
As icons are now available in SVG format and no more in PNG format, I made the change in this PR for battery icons. https://next.openhab.org/docs/ui/sitemaps.html#icons @stefan-hoehn : any idea what I should add to fix a size ? Edit: and note that we should update any link to an icon from classic iconset in the documentation. Do you know how to find them easily ? |
@lolodomo Good that you caught this (again something I should look more closely in the future!) I researched that a bit and played around with it to see what we could do. Unfortunately AFAIK there is no official way to tell markdown how to amend image sizes in the markdown image tag. There are some unofficial ways like adding the size this way ![Image](/img/battery-01.svg =64x64) which I tried it out but it doesn't work for us. So the only way that I am aware of to fix this special case is to use the html image tag (which we usually try to avoid) Can you try that out? |
I would say so, yes, can you try to make a PR and if it doesn't I am happy to look into it more closely. |
Related to openhab/openhab-core#3820
Signed-off-by: Laurent Garnier [email protected]