Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ide-vscode] Add instructions to tasks.json #2126

Merged
merged 3 commits into from
Nov 19, 2023
Merged

Conversation

Rosen01
Copy link
Contributor

@Rosen01 Rosen01 commented Aug 25, 2023

Add 3 tasks for Visual Studio Code IDE :

  • mvn Spotless (Fix codestyle)
  • mvn update properties (Default)
  • mvn update properties (Default) [full plug-in name]

Force code style update before compile.

Signed-off-by: Daniel Rosengarten [email protected]

Add 2 tasks for Visual Studio Code IDE.
Force code style update before compile.

Signed-off-by: Daniel Rosengarten <[email protected]>
@netlify
Copy link

netlify bot commented Aug 25, 2023

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit d4665d7
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/655a88bd9f701800084b248a
😎 Deploy Preview https://deploy-preview-2126--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Daniel Rosengarten <[email protected]>
Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thanks for contribution and I am very sorry it took me so long. I never had the time to really look into it and didn't just want to wave it through.

There is a minor change I like you to do.

On the other hand, I don't have a vsc setup, so it would be a lot of work for me to test it. However, it does look good to me.

I checked who also worked on that file and it seems @wborn may be using it.
Wouter would you mind having a quick look at that?

developers/ide/examples/vscode/tasks.json Outdated Show resolved Hide resolved
@stefan-hoehn stefan-hoehn requested a review from wborn November 19, 2023 13:06
@stefan-hoehn stefan-hoehn added this to the 4.1 milestone Nov 19, 2023
Signed-off-by: Daniel Rosengarten <[email protected]>
@Rosen01
Copy link
Contributor Author

Rosen01 commented Nov 19, 2023

I only develop with VS Code and I use the 2 first tasks to avoid check errors when I push updates (Velbus module).

@stefan-hoehn
Copy link
Contributor

Thanks, Daniel, I trust you in this that this is a proof it works.

@stefan-hoehn stefan-hoehn merged commit 2f83227 into openhab:main Nov 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants