-
-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ide-vscode] Add instructions to tasks.json #2126
Conversation
Add 2 tasks for Visual Studio Code IDE. Force code style update before compile. Signed-off-by: Daniel Rosengarten <[email protected]>
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Daniel Rosengarten <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thanks for contribution and I am very sorry it took me so long. I never had the time to really look into it and didn't just want to wave it through.
There is a minor change I like you to do.
On the other hand, I don't have a vsc setup, so it would be a lot of work for me to test it. However, it does look good to me.
I checked who also worked on that file and it seems @wborn may be using it.
Wouter would you mind having a quick look at that?
Signed-off-by: Daniel Rosengarten <[email protected]>
I only develop with VS Code and I use the 2 first tasks to avoid check errors when I push updates (Velbus module). |
Thanks, Daniel, I trust you in this that this is a proof it works. |
Add 3 tasks for Visual Studio Code IDE :
Force code style update before compile.
Signed-off-by: Daniel Rosengarten [email protected]