Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for SCRIPT transformation #1945

Merged
merged 2 commits into from
Dec 4, 2022

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Dec 4, 2022

Follow-up for #1940.

This clarifies that the file-extension has to be added inside the transformation pattern and adds an example for the transform pattern and fixes a few wording problems.

Reference openhab/openhab-core#2883 (comment).

@J-N-K This makes it clearer to me how to use the SCRIPT transformation profile.

This clarifies that the file-extension has to be added inside the transform pattern and adds an example for the transform pattern and fixes a few wording problems.
@netlify
Copy link

netlify bot commented Dec 4, 2022

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit 113ab34
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/638cc1be8fe45f00093d33da
😎 Deploy Preview https://deploy-preview-1945--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@J-N-K
Copy link
Member

J-N-K commented Dec 4, 2022

If you add that the script type is either the file-extension or the MIME-type, I can close my PR and we'll not run into merge conflicts.

State what the script-type is.

Signed-off-by: Florian Hotze <[email protected]>
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@florian-h05
Copy link
Contributor Author

@J-N-K Done ✅

@florian-h05
Copy link
Contributor Author

@Confectrician ping

Copy link
Contributor

@Confectrician Confectrician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 👍🏼

@Confectrician Confectrician merged commit a5b6708 into openhab:main Dec 4, 2022
@florian-h05 florian-h05 deleted the patch-1 branch December 4, 2022 17:59
@Confectrician Confectrician added this to the 3.4 milestone Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants