Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override pax logging version to address #1349. #1350

Closed
wants to merge 2 commits into from
Closed

Override pax logging version to address #1349. #1350

wants to merge 2 commits into from

Conversation

splatch
Copy link
Contributor

@splatch splatch commented Dec 16, 2021

Signed-off-by: Łukasz Dywicki [email protected]

@splatch splatch requested a review from a team as a code owner December 16, 2021 17:06
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/log4j-vulnerability/129863/73

@splatch
Copy link
Contributor Author

splatch commented Dec 16, 2021

Note - pax 2.0.10 is still listed in contents of archive, can be trimmed by ant or assembly mask. Runtime picks up 2.0.11 which is CVE clear. Feel free to backport it to 3.0.x and 3.1 versions. ;-)

@splatch splatch mentioned this pull request Dec 16, 2021
Closed
@kaikreuzer
Copy link
Member

Thanks for this fix, @splatch!
I'll keep this as a fallback, if we run into any issues with #1344.
But as Karaf 4.3.4 fixes some other issues as well, the plan would still be to release openHAB 3.2 directly with Karaf 4.3.4, so this additional fix won't be necessary.
Wrt backporting: Afaics, the criticality for openHAB isn't that high as log4j 2.15 already fixed the main/critical issue.
Assuming that most people on 3.x will anyhow update to 3.2, the effort to do yet another round of patch releases might not be worth it.

@jcz1
Copy link

jcz1 commented Dec 17, 2021

FYI 2.0.11 is vulnerable to CVE-2021-45046 (score changed to 9.0 / critical).

ops4j/org.ops4j.pax.logging#420

@wborn
Copy link
Member

wborn commented Dec 17, 2021

Thanks for the PR @splatch! I've made a few improvements in splatch#6, just in case the Karaf committee tries to spoil our release party. 🥳

@wborn @splatch
A few improvements
2ecea7e 
* Reverts openhab#1343 because Pax Logging 2.0.12 is not vulnerable.
* Excludes Pax Logging 2.0.10 to reduce archive size and to prevent scanner false positives.
* Adds missing new line.

Signed-off-by: Wouter Born <[email protected]>
@splatch
Copy link
Contributor Author

splatch commented Dec 17, 2021

Looks good, to be fair I didn't know the exclude stuff you used.
I don't think there are any show stoppers for Karaf 4.3.4 to get released, unless another surprise gets out of its dependencies ;-)

@splatch
Copy link
Contributor Author

splatch commented Dec 19, 2021

Solved through #1354

@splatch splatch closed this Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@splatch @openhab-bot @kaikreuzer @jcz1 @wborn @J-N-K