Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable ZigBee binding #1158

Merged
merged 1 commit into from
Oct 4, 2020
Merged

Reenable ZigBee binding #1158

merged 1 commit into from
Oct 4, 2020

Conversation

wborn
Copy link
Member

@wborn wborn commented Oct 3, 2020 •
edited
Loading

Also updates the versions and adds the new serial and console bundles.

CC: @cdjackson

@wborn wborn requested a review from a team October 3, 2020 07:58
@cdjackson
Copy link
Contributor

Thanks @wborn, however, can we instead start using the feature generated by the binding itself? I added this a few months back with a view that we can avoid having this feature file here - all dependencies would then be controlled in one place :)

@wborn
Copy link
Member Author

wborn commented Oct 3, 2020

I had a look at that and with a few changes it seems to work in general. However currently the generated feature name prevents it from showing up in the UI. The feature name should be openhab-binding-zigbee while it currently seems to be derived from the artifactId org.openhab.addons.features.karaf.zigbee .

@cdjackson cdjackson mentioned this pull request Oct 3, 2020
Merged
@wborn
Reenable ZigBee binding
1c0f5cc 
Adds the feature using the feature build in the zigbee repo.

Fixes openhab#1060

Signed-off-by: Wouter Born <[email protected]>
@wborn wborn linked an issue Oct 3, 2020 that may be closed by this pull request
Move ZigBee binding feature file to ZigBee repo #1060
Closed
@wborn wborn added rebuild Triggers a new PR build and removed rebuild Triggers a new PR build labels Oct 3, 2020
@wborn
Copy link
Member Author

wborn commented Oct 3, 2020

OK all is green now. Now we need to find one of the @openhab/distro-maintainers who wants to push the merge button.

kaikreuzer
kaikreuzer approved these changes Oct 4, 2020
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
So shall we also move the ZWave feature to its repo as a next step, @cdjackson?

@kaikreuzer kaikreuzer merged commit 48cc43d into openhab:master Oct 4, 2020
@wborn wborn deleted the reenable-zigbee branch October 4, 2020 09:50
@wborn wborn mentioned this pull request Oct 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move ZigBee binding feature file to ZigBee repo
3 participants
@wborn @cdjackson @kaikreuzer