Update ZSS ZigBee libraries to 1.2.9 #1043
Conversation
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
Signed-off-by: Chris Jackson <[email protected]>
cdjackson
force-pushed
the
zigbee-zss-1.2.8
branch
from
9f9767e to
2732860
Compare
cdjackson
changed the title
|
@kaikreuzer I recall discussing (with either @wborn or @Hilbrand) the possibility of removing the feature file from this repository and putting the relevant sections into the Is this possible at all? It would make the maintenance a lot easier. |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/zigbee-binding-slow-response/88566/15 |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
|
I can't remember discussing this, so I'm guessing it was with @wborn. But it seems more than logical to move these features to the specific repositories. I don't see why it wouldn't be possible. I'm not familiar with how to make this possible, but would assume something needs to be changed here, and maybe something in the pom's here/in the repos? The openhab-addons might be a reference to see how it works. For zigbee it would be similar to how bluetooth is handled in the openhab-addons repo. Maybe @wborn can help? |
|
Thanks @Hilbrand - I think it probably was with you while we were working through the bnd/IDE issues 4 or 5 months ago, but I can't find the discussion now. Either way, it doesn't matter too much - but if we can move the feature file so it's all in one place that would make maintenance a lot easier and more consistent. Thanks. |
|
We definitely had this discussion and I thought we even created an issue in the zwave/zigbee repos - but it seems that was forgotten. We definitely should change this, but only for master as we must not change anything about the feature GAVs and content for 2.5.x. So as the master branch of zwave/zigbee are currently not maintained, we will probably have to postpone this change until summer. @cdjackson Wrt this PR, I will merge it tomorrow after the 2.5.1 build as I want to avoid any risks that might be associated with it (due to its repo-distributed nature). |
|
Hi Kai,
I don’t remember such an issue in the Zigbee repo, but maybe it was missed somehow.
Please can we merge it before 2.5.1? Currently the binding doesn’t work at all so it can’t get any worse.
Chris
… On 11 Jan 2020, at 15:09, Hilbrand Bouwkamp ***@***.***> wrote:
I can't remember discussing this, so I'm guessing it was with @wborn <https://github.com/wborn>. But it seems more than logical to move these features to the specific repositories. I don't see why it wouldn't be possible. I'm not familiar with how to make this possible, but would assume something needs to be changed here, and maybe something in the pom's here/in the repos? The openhab-addons might be a reference to see how it works. For zigbee it would be similar to how bluetooth is handled in the openhab-addons repo. Maybe @wborn <https://github.com/wborn> can help?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#1043?email_source=notifications&email_token=AAH6IQ4RMTX26U27ASMY2YLQ5HOJTA5CNFSM4KCEKUQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWD4KQ#issuecomment-573324842>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH6IQYTDYEBH5HHSOYSBQDQ5HOJTANCNFSM4KCEKUQA>.
|
??? What do you mean? |
|
Well it’s not possible for it to be consistent as we have this problem where the binding has one configuration, and the distro has a different configuration. Since we can’t merge them both at the same time there will always be an inconsistency which is why I wanted to get the feature.xml into the ZigBee Binding repo. In any case, since I assumed that this would have been merged quickly I had merged the changes into the binding already.
If we merge this first, or the other one first, it will break. So, now it’s broken and I’ve been trying to get this merged for the last week or so, so if we can merge it, it would be appreciated.
… On 11 Jan 2020, at 19:58, Kai Kreuzer ***@***.***> wrote:
Currently the binding doesn’t work
??? What do you mean?
I hope you remember that the 2.5.x branch has to be stable all the time and not have any regressions or breaking changes to the 2.5.0 release. There will be a huge shitstorm tomorrow, if the Zigbee binding is completely broken when users receive 2.5.1.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#1043?email_source=notifications&email_token=AAH6IQ4TSESGPCGHH3456SDQ5IQFXA5CNFSM4KCEKUQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWJ35A#issuecomment-573349364>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH6IQ4Y6ULZ5NI7WUPLG7TQ5IQFXANCNFSM4KCEKUQA>.
|
|
We have often situations where PRs need to be merged at the same time, that is business as usual.
How? I cannot see a single comment here telling that it urgently needs to be merged... Also, as a maintainer make sure to follow the discussions in the group - just one day before you created this PR, I wrote here: "I'd suggest to do a 2.5.1 release on Jan 12 [...] So please consider this date and make sure to only merge stuff into 2.5.1 which is backward compatible and not too risky."
Ok, I hope what you meant is that it will be fully functional and successfully tested in the next snapshot distro - to get this done in time for 2.5.1, I'll merge it right away and also launch a build. |
This updates to the latest ZSmart Systems ZigBee Libraries
1.2.9. It also adds the console bundles into the feature so these are available to users without manual installation.Signed-off-by: Chris Jackson [email protected]