Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Karaf to 4.3.1 #1167

Closed
wborn opened this issue Oct 8, 2020 · 8 comments · Fixed by #1273
Closed

Upgrade Karaf to 4.3.1 #1167

wborn opened this issue Oct 8, 2020 · 8 comments · Fixed by #1273
Assignees
Labels
Milestone

Comments

@wborn
Copy link
Member

wborn commented Oct 8, 2020

These Karaf versions will be released soon so we should upgrade the Karaf version used in the distro to get the latest bugfixes and enhancements.

@wborn wborn added the karaf label Oct 8, 2020
@wborn wborn added this to the 3.0 milestone Oct 8, 2020
@wborn wborn self-assigned this Oct 9, 2020
@kaikreuzer kaikreuzer modified the milestones: 3.0.0.M1, 3.0 Oct 11, 2020
@wborn
Copy link
Member Author

wborn commented Oct 13, 2020

Let's wait for Karaf 4.2.11 because I found an annoying bug in 4.2.10 with the log:tail command (apache/karaf#1198 (comment)) which will hopefully be fixed soon in the 4.2.11 release. Other than that it seemed to work fine. 🙂

@wborn wborn changed the title Upgrade Karaf to 4.2.10 or 4.3.0 Upgrade Karaf to 4.2.11 or 4.3.0 Oct 13, 2020
@kaikreuzer
Copy link
Member

There are still no news on 4.2.11, but 4.3.0 is out instead and I assume it also contains the fix for the issue you've found.
Did you already do any tests with 4.3.0 as well? Should we aim for that, instead of 4.2.x?

@wborn
Copy link
Member Author

wborn commented Nov 22, 2020

There are still no news on 4.2.11

According to the download page "soon" is 2 months later. 😞

4.3.0 is out instead and I assume it also contains the fix for the issue

Yes it has the fix but I currently don't have time to test it and it is not that high prio for me. It doesn't look like we're missing out on 4.3.0 features (http://blog.nanthrax.net/?p=1038) at the moment to risk stability. Unless you want to start using newer Java versions or OSGi R7 features today. 😉

@kaikreuzer
Copy link
Member

According to the download page "soon" is 2 months later.

Ah, I should have scrolled down that page 😆 .
So that sounds rather a bit late for our release, maybe it's better then to keep it for openHAB 3.1 and then go for 4.3 or newer (even though I don't need R7 right now ;-))

@kaikreuzer
Copy link
Member

I've removed the issue from the openHAB 3 tracking.

@kaikreuzer kaikreuzer modified the milestones: 3.0, 3.1 Dec 22, 2020
@wborn wborn changed the title Upgrade Karaf to 4.2.11 or 4.3.0 Upgrade Karaf to 4.3.1 Dec 23, 2020
@wborn
Copy link
Member Author

wborn commented Mar 8, 2021

This weekend I successfully tested integrating Karaf 4.3.1-SNAPSHOT in OH 3.1 and it also seems to be released "soon". 😄

wborn added a commit to wborn/openhab-core that referenced this issue Mar 30, 2021
* Aligns compile dependencies with OSGi R7
* Aligns runtime dependencies with Karaf 4.3.1
* Fixes issues due to dependency changes:
  * AudioServletTest never ending due to Jetty upgrade
  * Feature resolution failing due to Karaf activation-api no longer visible
* Uses Pax Logging as runtime dependency instead of Felix Log
  This dependency change makes itests and Demo App behave more like the actual distro
  To change the log level in itests, change the value of org.ops4j.pax.logging.DefaultServiceLog.level in itest-include.bndrun
* Adds --add-opens and nashorn.args in itest-include.bndrun to prevent some warnings being logged in itests

Related to openhab/openhab-distro#1167

Signed-off-by: Wouter Born <[email protected]>
wborn added a commit to wborn/openhab-addons that referenced this issue Mar 30, 2021
* Upgrades Karaf to 4.3.1
* Uses Pax Logging as runtime dependency instead of Felix Log
  To change the log level in itests, change the value of org.ops4j.pax.logging.DefaultServiceLog.level in itest-include.bndrun
* Adds --add-opens and nashorn.args in itest-include.bndrun to prevent some warnings being logged in itests

Related to openhab/openhab-distro#1167

Signed-off-by: Wouter Born <[email protected]>
wborn added a commit to wborn/openhab-webui that referenced this issue Mar 30, 2021
wborn added a commit to wborn/openhab-distro that referenced this issue Mar 30, 2021
* Upgrades Karaf to 4.3.1
* Use Pax Logging as runtime dependency instead of Felix Log
  This dependency change makes the Demo App behave more like the actual distro.
  It also allows for using a single log4j2.xml which simplifies the logging config and makes it more like the distro.
  Fixes some noisy Pax Web commons-logging in the Demo App that would occur when using Felix Log.

The Log4j2 Demo App configuration is now very similar to that of the distro except for:

* Karaf specific logger configuration has been removed
* A commented example logger for a binding is added to help with debug logging

To allow for reconfiguring Log4j2 without making changes some enviroment variables can be used:

* The default root/openhab logger level can be overriden
* Several logger level/names can be reconfigured similarly

Fixes openhab#1167

Signed-off-by: Wouter Born <[email protected]>
@wborn
Copy link
Member Author

wborn commented Mar 30, 2021

As you can see I already created some draft PRs for upgrading to Karaf 4.3.1 which is currently on vote.
So if you can already review these changes, then we can merge the PRs when Karaf 4.3.1 is released later this week. 🙂

@wborn
Copy link
Member Author

wborn commented Apr 2, 2021

I've removed the draft status from my PRs since Karaf 4.3.1 has been released.

kaikreuzer pushed a commit to openhab/openhab-core that referenced this issue Apr 2, 2021
* Aligns compile dependencies with OSGi R7
* Aligns runtime dependencies with Karaf 4.3.1
* Fixes issues due to dependency changes:
  * AudioServletTest never ending due to Jetty upgrade
  * Feature resolution failing due to Karaf activation-api no longer visible
* Uses Pax Logging as runtime dependency instead of Felix Log
  This dependency change makes itests and Demo App behave more like the actual distro
  To change the log level in itests, change the value of org.ops4j.pax.logging.DefaultServiceLog.level in itest-include.bndrun
* Adds --add-opens and nashorn.args in itest-include.bndrun to prevent some warnings being logged in itests

Related to openhab/openhab-distro#1167

Signed-off-by: Wouter Born <[email protected]>
kaikreuzer pushed a commit to openhab/openhab-webui that referenced this issue Apr 2, 2021
kaikreuzer pushed a commit that referenced this issue Apr 2, 2021
* Upgrades Karaf to 4.3.1
* Use Pax Logging as runtime dependency instead of Felix Log
  This dependency change makes the Demo App behave more like the actual distro.
  It also allows for using a single log4j2.xml which simplifies the logging config and makes it more like the distro.
  Fixes some noisy Pax Web commons-logging in the Demo App that would occur when using Felix Log.

The Log4j2 Demo App configuration is now very similar to that of the distro except for:

* Karaf specific logger configuration has been removed
* A commented example logger for a binding is added to help with debug logging

To allow for reconfiguring Log4j2 without making changes some enviroment variables can be used:

* The default root/openhab logger level can be overriden
* Several logger level/names can be reconfigured similarly

Fixes #1167

Signed-off-by: Wouter Born <[email protected]>
kaikreuzer pushed a commit to openhab/openhab-addons that referenced this issue Apr 2, 2021
* Upgrades Karaf to 4.3.1
* Uses Pax Logging as runtime dependency instead of Felix Log
  To change the log level in itests, change the value of org.ops4j.pax.logging.DefaultServiceLog.level in itest-include.bndrun
* Adds --add-opens and nashorn.args in itest-include.bndrun to prevent some warnings being logged in itests

Related to openhab/openhab-distro#1167

Signed-off-by: Wouter Born <[email protected]>
Daniel-42 pushed a commit to Daniel-42/openhab-addons that referenced this issue Apr 6, 2021
* Upgrades Karaf to 4.3.1
* Uses Pax Logging as runtime dependency instead of Felix Log
  To change the log level in itests, change the value of org.ops4j.pax.logging.DefaultServiceLog.level in itest-include.bndrun
* Adds --add-opens and nashorn.args in itest-include.bndrun to prevent some warnings being logged in itests

Related to openhab/openhab-distro#1167

Signed-off-by: Wouter Born <[email protected]>
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this issue May 10, 2021
* Upgrades Karaf to 4.3.1
* Uses Pax Logging as runtime dependency instead of Felix Log
  To change the log level in itests, change the value of org.ops4j.pax.logging.DefaultServiceLog.level in itest-include.bndrun
* Adds --add-opens and nashorn.args in itest-include.bndrun to prevent some warnings being logged in itests

Related to openhab/openhab-distro#1167

Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: John Marshall <[email protected]>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this issue Jul 13, 2021
* Upgrades Karaf to 4.3.1
* Uses Pax Logging as runtime dependency instead of Felix Log
  To change the log level in itests, change the value of org.ops4j.pax.logging.DefaultServiceLog.level in itest-include.bndrun
* Adds --add-opens and nashorn.args in itest-include.bndrun to prevent some warnings being logged in itests

Related to openhab/openhab-distro#1167

Signed-off-by: Wouter Born <[email protected]>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this issue Nov 7, 2021
* Upgrades Karaf to 4.3.1
* Uses Pax Logging as runtime dependency instead of Felix Log
  To change the log level in itests, change the value of org.ops4j.pax.logging.DefaultServiceLog.level in itest-include.bndrun
* Adds --add-opens and nashorn.args in itest-include.bndrun to prevent some warnings being logged in itests

Related to openhab/openhab-distro#1167

Signed-off-by: Wouter Born <[email protected]>
marcfischerboschio pushed a commit to marcfischerboschio/openHABaddon that referenced this issue Apr 20, 2022
* Upgrades Karaf to 4.3.1
* Uses Pax Logging as runtime dependency instead of Felix Log
  To change the log level in itests, change the value of org.ops4j.pax.logging.DefaultServiceLog.level in itest-include.bndrun
* Adds --add-opens and nashorn.args in itest-include.bndrun to prevent some warnings being logged in itests

Related to openhab/openhab-distro#1167

Signed-off-by: Wouter Born <[email protected]>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this issue Jul 11, 2023
* Aligns compile dependencies with OSGi R7
* Aligns runtime dependencies with Karaf 4.3.1
* Fixes issues due to dependency changes:
  * AudioServletTest never ending due to Jetty upgrade
  * Feature resolution failing due to Karaf activation-api no longer visible
* Uses Pax Logging as runtime dependency instead of Felix Log
  This dependency change makes itests and Demo App behave more like the actual distro
  To change the log level in itests, change the value of org.ops4j.pax.logging.DefaultServiceLog.level in itest-include.bndrun
* Adds --add-opens and nashorn.args in itest-include.bndrun to prevent some warnings being logged in itests

Related to openhab/openhab-distro#1167

Signed-off-by: Wouter Born <[email protected]>
GitOrigin-RevId: ef1b86c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants