Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSL] New implicit variable newState #973

Merged
merged 1 commit into from
Aug 13, 2019
Merged

[DSL] New implicit variable newState #973

merged 1 commit into from
Aug 13, 2019

Conversation

lolodomo
Copy link
Contributor

Fix #925

Signed-off-by: Laurent Garnier [email protected]

Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Nice and useful enhancement. Looking forward for an extended documentation. Thanks.

Would be really nice to have some unit tests for these predefined variables. But unfortunately the itest for DSL rules does not run properly yet.

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, many thanks for picking this up!

@kaikreuzer kaikreuzer merged commit 0820701 into openhab:master Aug 13, 2019
@lolodomo lolodomo deleted the DSL_newState branch August 13, 2019 19:15
@cweitkamp cweitkamp added this to the 2.5 milestone Aug 13, 2019
@cweitkamp cweitkamp added DSL Domain-Specific Language enhancement An enhancement or new feature of the Core labels Aug 13, 2019
@cweitkamp cweitkamp changed the title [DSL rule] New implicit variable newState [DSL] New implicit variable newState Dec 3, 2019
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/rule-trigger-speed-issue-missing-status-updates/62049/17

splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DSL Domain-Specific Language enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rule DSL] Introduce "newState" as a new implicit variable in rules with state triggers
4 participants