Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements of hexutils API and implementation #862

Merged
merged 2 commits into from
Jun 10, 2019
Merged

Small improvements of hexutils API and implementation #862

merged 2 commits into from
Jun 10, 2019

Conversation

maggu2810
Copy link
Contributor

  • improve HexUtils; e.g. don't create Byte array just to copy its content to a byte array
  • migrate the HexUtils integration test to a normal JUnit test

wborn
wborn approved these changes Jun 10, 2019
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It makes a lot of sense to turn this hotspot into some tight code by removing the lambda, using primitives and a StringBuilder. 👍

@wborn wborn merged commit 849753b into openhab:master Jun 10, 2019
@maggu2810 maggu2810 deleted the hexutils branch June 10, 2019 15:13
@wborn wborn added this to the 2.5 milestone Jul 30, 2019
@cweitkamp cweitkamp changed the title small improvements of hexutils API and impl. Small improvements of hexutils API and implementation Dec 7, 2019
@cweitkamp cweitkamp added the enhancement An enhancement or new feature of the Core label Dec 7, 2019
Rosi2143 pushed a commit to Rosi2143/openhab-core that referenced this pull request Dec 26, 2020
@LightIsLife @ghys
Introduction: add .html to links, add logo (openhab#862)
36d1626 
Also-by: Yannick Schaus <[email protected]>
Signed-off-by: Markus Lipp [email protected] (github: LightIsLife)
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
@maggu2810 @splatch
small improvements of hexutils API and impl. (openhab#862)
c9fbe22 
Signed-off-by: Markus Rathgeb <[email protected]>
GitOrigin-RevId: 849753b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.
3 participants
@maggu2810 @wborn @cweitkamp