Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Added new parent class for units to fix import problems #618

Merged
merged 1 commit into from
Mar 2, 2019

Conversation

Hilbrand
Copy link
Member

@Hilbrand Hilbrand commented Mar 2, 2019

The change with unit classes parent (#617) causes it to report missing imports of tec.uom.se when using static import. Before the change this was not a problem because the parent class was SmartHomeUnits. This change adds a new parent class for all units.

The change with unit classes parent (openhab#617) causes it to report missing imports of tec.uom.se when using static import. Before the change this was not a problem because the parent class was SmartHomeUnits. This change adds a new parent class for all units.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
@wborn
Copy link
Member

wborn commented Mar 2, 2019

Nice. This way we can also use static imports again with SmartHomeUnits. :-)

@wborn wborn merged commit caa9b71 into openhab:master Mar 2, 2019
@Hilbrand Hilbrand deleted the units branch March 2, 2019 13:39
@wborn wborn added the UoM Units of Measurement label Mar 5, 2019
@wborn wborn added this to the 2.5 milestone Mar 5, 2019
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/started-getting-compile-error-after-mvn-clean/69799/3

@cweitkamp cweitkamp added the enhancement An enhancement or new feature of the Core label Dec 7, 2019
@cweitkamp cweitkamp changed the title Added new parent class for units to fix import problems. [core] Added new parent class for units to fix import problems Dec 7, 2019
@kaikreuzer kaikreuzer removed the enhancement An enhancement or new feature of the Core label Dec 13, 2019
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
The change with unit classes parent (openhab#617) causes it to report missing imports of tec.uom.se when using static import. Before the change this was not a problem because the parent class was SmartHomeUnits. This change adds a new parent class for all units.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
GitOrigin-RevId: caa9b71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UoM Units of Measurement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants