[rest] Fix ThingActionsResource does not accept new Thing action UIDs with hash #4445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… due to wrong path RegEx Signed-off-by: Florian Hotze <[email protected]>
|
Probably correct |
J-N-K
requested changes
Nov 10, 2024
| @Path("/{thingUID}/{actionUid: [a-zA-Z0-9]+\\.[a-zA-Z0-9]+}") | ||
| // accept actionUid in the form of "scope.actionTypeUid" or "scope.actionTypeUid#signatureHash" | ||
| // # is URL encoded as %23 | ||
| @Path("/{thingUID}/{actionUid: [a-zA-Z0-9]+\\.[a-zA-Z0-9]+(%23[a-zA-Z0-9]+)?}") |
There was a problem hiding this comment.
The hash is a hex string, correct? In that case A-Fa-f0-9 would be sufficient. Since we do a lookup on the hash and that is case-sensitive it Coups be a good idea to also restrict that.
There was a problem hiding this comment.
Makes sense, just implemented and pushed that.
Local test looks good.
Signed-off-by: Florian Hotze <[email protected]>
J-N-K
approved these changes
Nov 11, 2024
|
Can someone please trigger a new snapshot build? |
|
It's already done: https://ci.openhab.org/job/openHAB-Core/58/changes (for core that is - not yet the distro). |
|
Now there's also a new distro for testing: https://ci.openhab.org/job/openHAB-Distribution/4374/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #4441.