Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Xtext/Xtend to 2.36.0 #4398

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Upgrade Xtext/Xtend to 2.36.0 #4398

merged 2 commits into from
Oct 5, 2024

Conversation

holgerfriedrich
Copy link
Member

Xtend 2.36 enables the new annotation XbaseGenerated by default and has a known issue with the code generator.
eclipse-xtext/xtext#3182 which has been fixed after the release of 2.36.
The second commit of this PR disables the annotation on 3 subdirectories - a workaround which can be removed once there is a new release.

Please do not squash during merge.

Workaround for issue in xtext code generator in xtext 2.36, see
eclipse-xtext/xtext#3182.

Signed-off-by: Holger Friedrich <[email protected]>
* Upgrade Xtext/Xtend from 2.35.0 to 2.36.0, see release notes:
  https://eclipse.dev/Xtext/releasenotes.html#/releasenotes/2024/08/25/version-2-36-0
  https://eclipse.dev/Xtext/xtend/releasenotes.html#/releasenotes/2024/08/25/version-2-36-0
* Upgrade dependencies
  * Guava from 33.2.0 to 33.3.0
  * Classgraph from 4.8.172 to 4.8.174

Signed-off-by: Holger Friedrich <[email protected]>
@holgerfriedrich holgerfriedrich requested a review from a team as a code owner October 1, 2024 21:56
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upgrade!
I gave it a brief test and it still works. 👍

@wborn wborn merged commit 22eec8c into openhab:main Oct 5, 2024
5 checks passed
@wborn wborn added this to the 4.3 milestone Oct 5, 2024
@wborn wborn added the enhancement An enhancement or new feature of the Core label Oct 5, 2024
wborn added a commit to wborn/openhab-addons that referenced this pull request Oct 5, 2024
wborn added a commit to wborn/openhab-distro that referenced this pull request Oct 5, 2024
@holgerfriedrich holgerfriedrich deleted the pr-xtend branch October 5, 2024 15:39
kaikreuzer pushed a commit to openhab/openhab-distro that referenced this pull request Oct 5, 2024
wborn added a commit to openhab/openhab-addons that referenced this pull request Oct 6, 2024
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants