-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Xtext/Xtend to 2.36.0 #4398
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for issue in xtext code generator in xtext 2.36, see eclipse-xtext/xtext#3182. Signed-off-by: Holger Friedrich <[email protected]>
* Upgrade Xtext/Xtend from 2.35.0 to 2.36.0, see release notes: https://eclipse.dev/Xtext/releasenotes.html#/releasenotes/2024/08/25/version-2-36-0 https://eclipse.dev/Xtext/xtend/releasenotes.html#/releasenotes/2024/08/25/version-2-36-0 * Upgrade dependencies * Guava from 33.2.0 to 33.3.0 * Classgraph from 4.8.172 to 4.8.174 Signed-off-by: Holger Friedrich <[email protected]>
wborn
approved these changes
Oct 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the upgrade!
I gave it a brief test and it still works. 👍
wborn
added a commit
to wborn/openhab-addons
that referenced
this pull request
Oct 5, 2024
Related to: * openhab/openhab-core#4398 * openhab/openhab-core#4403 Signed-off-by: Wouter Born <[email protected]>
wborn
added a commit
to wborn/openhab-distro
that referenced
this pull request
Oct 5, 2024
Related to: * openhab/openhab-core#4398 * openhab/openhab-core#4403 Signed-off-by: Wouter Born <[email protected]>
kaikreuzer
pushed a commit
to openhab/openhab-distro
that referenced
this pull request
Oct 5, 2024
Related to: * openhab/openhab-core#4398 * openhab/openhab-core#4403 Signed-off-by: Wouter Born <[email protected]>
wborn
added a commit
to openhab/openhab-addons
that referenced
this pull request
Oct 6, 2024
Related to: * openhab/openhab-core#4398 * openhab/openhab-core#4403 Signed-off-by: Wouter Born <[email protected]>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
Related to: * openhab/openhab-core#4398 * openhab/openhab-core#4403 Signed-off-by: Wouter Born <[email protected]>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
Related to: * openhab/openhab-core#4398 * openhab/openhab-core#4403 Signed-off-by: Wouter Born <[email protected]>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
Related to: * openhab/openhab-core#4398 * openhab/openhab-core#4403 Signed-off-by: Wouter Born <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eclipse.dev/Xtext/releasenotes.html#/releasenotes/2024/08/25/version-2-36-0
https://eclipse.dev/Xtext/xtend/releasenotes.html#/releasenotes/2024/08/25/version-2-36-0
Xtend 2.36 enables the new annotation XbaseGenerated by default and has a known issue with the code generator.
eclipse-xtext/xtext#3182 which has been fixed after the release of 2.36.
The second commit of this PR disables the annotation on 3 subdirectories - a workaround which can be removed once there is a new release.
Please do not squash during merge.