Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a log when loading a YAML file #3916

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

lolodomo
Copy link
Contributor

For consistency with other model files loading.

Signed-off-by: Laurent Garnier [email protected]

For consistency with other model files loading.

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo requested a review from a team as a code owner December 11, 2023 19:07
@lolodomo
Copy link
Contributor Author

@J-N-K : can you please merge that ?

I just tested snapshot 3767 and the loading of YAML files for semantic tags is working well, but it was strange to not see file loading in logs while it is shown for all other files.

@J-N-K J-N-K added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels Dec 12, 2023
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaikreuzer kaikreuzer merged commit 4b92db3 into openhab:main Dec 13, 2023
3 checks passed
@kaikreuzer kaikreuzer added this to the 4.1 milestone Dec 13, 2023
@lolodomo lolodomo deleted the log_loading_tags branch December 13, 2023 07:30
andrewfg pushed a commit to andrewfg/openhab-core that referenced this pull request Dec 17, 2023
For consistency with other model files loading.

Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants