Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging in AbstractProvider implementations #3751

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Fix logging in AbstractProvider implementations #3751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ....persistence/src/org/openhab/core/model/persistence/internal/PersistenceModelManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@
import org.osgi.service.component.annotations.Component;
import org.osgi.service.component.annotations.Deactivate;
import org.osgi.service.component.annotations.Reference;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/**
* This class is the central part of the persistence management and delegation. It reads the persistence
Expand All @@ -70,6 +72,7 @@
@NonNullByDefault
public class PersistenceModelManager extends AbstractProvider<PersistenceServiceConfiguration>
implements ModelRepositoryChangeListener, PersistenceServiceConfigurationProvider {
private final Logger logger = LoggerFactory.getLogger(PersistenceModelManager.class);
private final Map<String, PersistenceServiceConfiguration> configurations = new ConcurrentHashMap<>();
private final ModelRepository modelRepository;

Expand Down
3 changes: 3 additions & 0 deletions ...model.thing/src/org/openhab/core/model/thing/internal/GenericItemChannelLinkProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@
import org.openhab.core.thing.link.ItemChannelLink;
import org.openhab.core.thing.link.ItemChannelLinkProvider;
import org.osgi.service.component.annotations.Component;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/**
* {@link GenericItemChannelLinkProvider} link items to channel by reading bindings with type "channel".
Expand All @@ -43,6 +45,7 @@
public class GenericItemChannelLinkProvider extends AbstractProvider<ItemChannelLink>
implements BindingConfigReader, ItemChannelLinkProvider {

private final Logger logger = LoggerFactory.getLogger(GenericItemChannelLinkProvider.class);
/** caches binding configurations. maps itemNames to {@link BindingConfig}s */
protected Map<String, Set<ItemChannelLink>> itemChannelLinkMap = new ConcurrentHashMap<>();

Expand Down
2 changes: 1 addition & 1 deletion ...les/org.openhab.core/src/main/java/org/openhab/core/common/registry/AbstractProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ private enum EventType {
UPDATED
}

protected final Logger logger = LoggerFactory.getLogger(AbstractProvider.class);
private Logger logger = LoggerFactory.getLogger(AbstractProvider.class);
protected List<ProviderChangeListener<E>> listeners = new CopyOnWriteArrayList<>();

@Override
Expand Down