Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CommunicationManager command handling #3714

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Fix CommunicationManager command handling #3714

merged 3 commits into from
Sep 13, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jul 19, 2023

Fixes #3694

@J-N-K
Fix CommunicationManager
061c836 
Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Jul 19, 2023
@J-N-K J-N-K requested a review from a team as a code owner July 19, 2023 17:40
@J-N-K J-N-K changed the title Fix CommunicationManager Fix CommunicationManager command handling Jul 19, 2023
J-N-K added 2 commits July 19, 2023 20:08
@J-N-K
Fix wrong context
95561e8 
Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K
fix
d58a4a6 
Signed-off-by: Jan N. Klug <[email protected]>
@kaikreuzer
Copy link
Member

Lgtm in general, but I also cannot judge on possible side effects. It might be too risky to merge it one day before the RC.
Shall we better wait and only merge it for 4.1?

@J-N-K
Copy link
Member Author

J-N-K commented Jul 21, 2023

The problem is that I'm not sure if this worked before (in 3.4) and is a regression from the CommunicationManager refactoring.

@kaikreuzer
Copy link
Member

It is a fairly rare use case, so I'd rather live with that regression than to potentially introduce other ones unintentionally now.

@J-N-K
Copy link
Member Author

J-N-K commented Jul 21, 2023

Fine. We can also do a 4.0.1 if it turns out to be a bigger issue.

@wborn
Copy link
Member

wborn commented Aug 20, 2023

Shall we better wait and only merge it for 4.1?

Perhaps we can merge it now?

kaikreuzer
kaikreuzer approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. :-)

@kaikreuzer kaikreuzer merged commit af4fce1 into openhab:main Sep 13, 2023
@kaikreuzer kaikreuzer added this to the 4.1 milestone Sep 13, 2023
@J-N-K J-N-K deleted the fix-communicationmanager branch September 14, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Profile JS Transformation Item -> Thing for Datatype Datetime not triggered
3 participants
@J-N-K @kaikreuzer @wborn