Use Eclipse formatter 4.25 with Spotless #3710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem with 4.25 is something with |
No previously we used 4.21 and we upgraded to 4.26 in #3469. Messed up spaces only return if you run:
|
|
I now also tested the newer Spotless and Eclipse formatter versions but they still don't fix the issue that it does not check/apply test files. |
wborn
changed the title
Fixes openhab#3515 Signed-off-by: Wouter Born <[email protected]>
J-N-K
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result after running:
mvn spotless:apply -Dspotless.eclipse.version=4.25Perhaps we should just revert the version in the property?
I still don't know of any negative side effects and the PR will probably also build successfully while it is uses 4.26.
See also #3515 (comment).