Fix wrong event subscription in CommunicationManager
#3529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#3141 introduced an ItemStateUpdatedEvent and updated CommunicationManager to require this for sending state updates. However, it was forgotten to update the subscribed event types. Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
|
LGTM, why is this a draft? |
|
I wanted to test this on my production, but I am finished now 👍 This fixes openhab/openhab-addons#14753 according to my tests, which is logical: state updates are now again relayed to the thing and therefore send to the KNX bus. |
J-N-K
added
bug
|
The CI / Build action seems unstable, it already failed two times because of the |
|
CI will be more stable after #3518 is merged. |
|
CI finally succeeded 🥳 |
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
* Fix wrong event subscription in CommunicationManager Signed-off-by: Florian Hotze <[email protected]> GitOrigin-RevId: 633002c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3141 introduced an
ItemStateUpdatedEventand updatedCommunicationManagerto only receive updates on this event.However, it was forgotten to update the subscribed event types, so no updated were received at all.
The
CommuncationManagerOSGiTestwas not able to detect this regression, because in the test the event isreceivedvia a method call, but not an event subscription/the event bus.This also renames the method for creating a
GroupStateUpdatedEventfor more clarity.