made http transport part of core installation #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Kreuzer <[email protected]>
martinvw
reviewed
May 18, 2018
|
|
||
| <feature name="openhab-transport-http" description="HTTP Transport" version="${project.version}"> | ||
| <feature>openhab-httpclient</feature> | ||
| <feature>esh-io-transport-http</feature> |
There was a problem hiding this comment.
No, but it also rather causes issues as it refers to Jetty 9.3.15 - so it should be safer to leave it out.
martinvw
approved these changes
May 18, 2018
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
Signed-off-by: Kai Kreuzer <[email protected]> GitOrigin-RevId: fb11962
wborn
added a commit
to wborn/openhab-addons
that referenced
this pull request
Jan 4, 2024
The openhab-transport-http feature dependency is redundant since OH 2.3 when it was added to the openhab-runtime-base feature dependencies. See: * openhab/openhab-core#344 * openhab#16181 (comment) Signed-off-by: Wouter Born <[email protected]>
J-N-K
pushed a commit
to openhab/openhab-addons
that referenced
this pull request
Jan 4, 2024
The openhab-transport-http feature dependency is redundant since OH 2.3 when it was added to the openhab-runtime-base feature dependencies. See: * openhab/openhab-core#344 * #16181 (comment) Signed-off-by: Wouter Born <[email protected]>
Cybso
pushed a commit
to Cybso/openhab-addons
that referenced
this pull request
Jan 5, 2024
The openhab-transport-http feature dependency is redundant since OH 2.3 when it was added to the openhab-runtime-base feature dependencies. See: * openhab/openhab-core#344 * openhab#16181 (comment) Signed-off-by: Wouter Born <[email protected]>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
The openhab-transport-http feature dependency is redundant since OH 2.3 when it was added to the openhab-runtime-base feature dependencies. See: * openhab/openhab-core#344 * openhab#16181 (comment) Signed-off-by: Wouter Born <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
The openhab-transport-http feature dependency is redundant since OH 2.3 when it was added to the openhab-runtime-base feature dependencies. See: * openhab/openhab-core#344 * openhab#16181 (comment) Signed-off-by: Wouter Born <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the change of openhab/openhab-distro#706, I noticed that installing the websocket client during runtime causes the whole UPnP+Jetty stack (including http server) to restart, which causes all kinds of issues.
As the http transport only adds 2 additional bundles (the rest is usually already there), I think it is the better option to simply include those in the core installation already.
Signed-off-by: Kai Kreuzer [email protected]