Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Xtext/Xtend to 2.26.0, LSP4J to 0.12.0 #2786

Merged
merged 1 commit into from
Mar 5, 2022
Merged

Upgrade Xtext/Xtend to 2.26.0, LSP4J to 0.12.0 #2786

merged 1 commit into from
Mar 5, 2022

Conversation

wborn
Copy link
Member

@wborn wborn commented Feb 19, 2022 •
edited
Loading

For release notes, see:

https://www.eclipse.org/Xtext/releasenotes.html#/releasenotes/2022/02/28/version-2-26-0

This release adds initial support for Java 17.

Related to openhab/openhab-distro#1316.

We'll also need to add a few Eclipse Orbit bundles to the openHAB Maven repo.
To test build this PR locally, you can download and install these using:

wget https://download.eclipse.org/releases/2022-03/202202041000/plugins/com.google.inject_5.0.1.v20210324-2015.jar
mvn install:install-file -Dfile=./com.google.inject_5.0.1.v20210324-2015.jar -DgroupId=org.eclipse.orbit.bundles -DartifactId=com.google.inject -Dversion=5.0.1.v20210324-2015 -Dpackaging=jar

wget https://download.eclipse.org/releases/2021-06/202106161001/plugins/org.aopalliance_1.0.0.v201105210816.jar
mvn install:install-file -Dfile=./org.aopalliance_1.0.0.v201105210816.jar -DgroupId=org.eclipse.orbit.bundles -DartifactId=org.aopalliance -Dversion=1.0.0.v201105210816 -Dpackaging=jar

wget https://download.eclipse.org/releases/2022-03/202202041000/plugins/io.github.classgraph_4.8.138.v20211212-1642.jar
mvn install:install-file -Dfile=./io.github.classgraph_4.8.138.v20211212-1642.jar -DgroupId=org.eclipse.orbit.bundles -DartifactId=io.github.classgraph -Dversion=4.8.138.v20211212-1642 -Dpackaging=jar

After also fixing #2787 I was able to get DSL rules working with Java 17. 🥳

@wborn wborn added the dependencies Pull requests that update a dependency file label Feb 19, 2022
@wborn wborn mentioned this pull request Feb 19, 2022
Closed
9 tasks
@wborn wborn added the enhancement An enhancement or new feature of the Core label Feb 19, 2022
@wborn wborn mentioned this pull request Feb 19, 2022
Closed
25 tasks
@wborn wborn added the work in progress A PR that is not yet ready to be merged label Feb 20, 2022
@wborn wborn added the awaiting external dependency Depends on a new version of an external dependency label Feb 26, 2022
@wborn
Upgrade Xtext/Xtend to 2.26.0, LSP4J to 0.12.0
bb4963d 
For release notes, see:

https://www.eclipse.org/Xtext/releasenotes.html#/releasenotes/2022/02/28/version-2-26-0

This release adds initial support for Java 17.

Signed-off-by: Wouter Born <[email protected]>
@wborn wborn removed work in progress A PR that is not yet ready to be merged awaiting external dependency Depends on a new version of an external dependency labels Feb 28, 2022
@wborn wborn marked this pull request as ready for review February 28, 2022 10:27
@wborn wborn requested a review from a team as a code owner February 28, 2022 10:27
wborn added a commit to wborn/openhab-distro that referenced this pull request Feb 28, 2022
@wborn
Resolve runbundles for Xtext upgrade
106fce0 
Depends on openhab/openhab-core#2786

Signed-off-by: Wouter Born <[email protected]>
wborn added a commit to wborn/openhab-addons that referenced this pull request Feb 28, 2022
@wborn
Resolve runbundles for Xtext upgrade
4db5917 
Depends on openhab/openhab-core#2786

Signed-off-by: Wouter Born <[email protected]>
This was referenced Feb 28, 2022
Merged
Merged
@wborn
Copy link
Member Author

wborn commented Feb 28, 2022

Xtext 2.26.0 has been released. Can you add the 3 Orbit bundles mentioned in #2786 (comment) to the openHAB Maven repo @kaikreuzer? When they can be downloaded, this PR should build successfully.

@kaikreuzer kaikreuzer added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels Mar 5, 2022
kaikreuzer
kaikreuzer approved these changes Mar 5, 2022
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green, awesome. 👍

@kaikreuzer kaikreuzer merged commit 44f9baf into openhab:main Mar 5, 2022
@kaikreuzer kaikreuzer added this to the 3.3 milestone Mar 5, 2022
@wborn
Copy link
Member Author

wborn commented Mar 5, 2022

Thank you too for uploading the bundles! 🙂

@wborn wborn deleted the xtext-2.26.0 branch March 5, 2022 10:30
lolodomo pushed a commit to openhab/openhab-addons that referenced this pull request Mar 5, 2022
@wborn
Resolve runbundles for Xtext upgrade (#12385)
52c21a3 
Depends on openhab/openhab-core#2786

Signed-off-by: Wouter Born <[email protected]>
kaikreuzer pushed a commit to openhab/openhab-distro that referenced this pull request Mar 5, 2022
@wborn
Resolve runbundles for Xtext upgrade (#1372)
54c6277 
Depends on openhab/openhab-core#2786

Signed-off-by: Wouter Born <[email protected]>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
@wborn @NickWaterton
Resolve runbundles for Xtext upgrade (openhab#12385)
d5ab402 
Depends on openhab/openhab-core#2786

Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Nick Waterton <[email protected]>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@wborn @andan67
Resolve runbundles for Xtext upgrade (openhab#12385)
c349f11 
Depends on openhab/openhab-core#2786

Signed-off-by: Wouter Born <[email protected]>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@wborn @andrasU
Resolve runbundles for Xtext upgrade (openhab#12385)
5103e2e 
Depends on openhab/openhab-core#2786

Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Andras Uhrin <[email protected]>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@wborn @psmedley
Resolve runbundles for Xtext upgrade (openhab#12385)
2428696 
Depends on openhab/openhab-core#2786

Signed-off-by: Wouter Born <[email protected]>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@wborn @splatch
Upgrade Xtext/Xtend to 2.26.0, LSP4J to 0.12.0 (openhab#2786)
da69dc3 
For release notes, see:

https://www.eclipse.org/Xtext/releasenotes.html#/releasenotes/2022/02/28/version-2-26-0

This release adds initial support for Java 17.

Signed-off-by: Wouter Born <[email protected]>
GitOrigin-RevId: 44f9baf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@wborn @kaikreuzer