Add triggeringThing name to DSL rules #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Melville <[email protected]>
Signed-off-by: James Melville <[email protected]>
kaikreuzer
approved these changes
Feb 13, 2022
There was a problem hiding this comment.
Lgtm, thanks for the addition.
Could you please also create a PR to add these new implicit vars to the docs at https://www.openhab.org/docs/configuration/rules-dsl.html#implicit-variables-inside-the-execution-block?
jamesmelville
added a commit
to jamesmelville/openhab-docs
that referenced
this pull request
Feb 13, 2022
Changes made in openhab/openhab-core#2756 Signed-off-by: James Melville <[email protected]>
Confectrician
pushed a commit
to openhab/openhab-docs
that referenced
this pull request
Feb 15, 2022
Changes made in openhab/openhab-core#2756 Signed-off-by: James Melville <[email protected]>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/get-event-triggering-thing/134588/5 |
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
* Add triggeringThing name to DSL rules * Include previous and new statuses Signed-off-by: James Melville <[email protected]> GitOrigin-RevId: 805f223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to be able to detect which thing had triggered a DSL rule in order to write rules which used a single set of functionality when detecting that one of many things had gone offline. Whilst I was at it I figured it might be useful to include the previous and new statuses and remove the reference to previousState which didn't seem to make sense. I've tried to follow the pattern in the code and this PR #2567